test: bump 10s timeouts that flake on Flat DB CI#11380
Conversation
RpcTest.TestSerializedRequest hard-cancels after 10s; under TEST_USE_FLAT=1 engine_newPayloadV5 plus JSON serialization exceeds that, causing TaskCanceledException in V6 BAL tests. executePayloadV1_accepts_already_known_block(true) trips its [CancelAfter(10000)] on the same workflow. Bump both to 30s so CI has headroom; tests still complete in under 10s when not under load.
|
Claude finished @LukaszRozmej's task in 1m 3s —— View job Review
This is a focused, minimal fix for CI flakiness under Finding: Low —
Finding: Low — potentially missed sibling timeout
No critical, high, or medium findings. The fix is correct and proportionate to the problem. Mergeable. |
Same root cause: TEST_USE_FLAT=1 makes block production / forkchoice slow enough to clip these tests' cancellation tokens. - getPayloadV1_picks_transactions_from_pool_v1: 10s -> 30s - executePayloadV1_on_top_of_terminal_block: 5s -> 30s - executePayloadV1_on_top_of_not_processed_invalid_terminal_block: 5s -> 30s - Maintain_correct_pointers_for_beacon_sync_in_archive_sync: 5s -> 30s
executePayloadV1_accepts_already_known_block(true) trips TaskCanceledException at 10s 489ms inside TestBlockchain.Build() on TEST_USE_FLAT=1 runs. The wait there uses this.CancellationToken, which is fed by TestTimeout (= DefaultTimeout), not the test's [CancelAfter(30000)]. PR #11380 bumped per-test [CancelAfter] values but missed this internal one; aligning the default with that fix. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#11731) test: bump executePayloadV1_accepts_already_known_block CancelAfter to 60s Test has flaked again on Flat DB CI at the 30s cap (originally bumped from 10s in #11380). bestBlockProcessed.WaitAsync exceeds 30s on slow runners. Aligning with the 60s NewPayloadBlockProcessingTimeout already used in MergeTestBlockchain.
Changes
RpcTest.TestSerializedRequest: bump cancellation token from 10s → 30s. UnderTEST_USE_FLAT=1engine_newPayloadV5 + JSON serialization can exceed 10s, throwingTaskCanceledException(e.g.NewPayloadV5_rejects_invalid_BAL_early(...,SurplusReads)15s).executePayloadV1_accepts_already_known_block: bump[CancelAfter(10000)]→[CancelAfter(30000)]. Same root cause — flat DB block production is just slower.Both tests still complete well under 10s when not under CI load. Verified locally with
TEST_USE_FLAT=1:Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes