test: bump TestBlockchain.DefaultTimeout 10s -> 30s#11486
Conversation
executePayloadV1_accepts_already_known_block(true) trips TaskCanceledException at 10s 489ms inside TestBlockchain.Build() on TEST_USE_FLAT=1 runs. The wait there uses this.CancellationToken, which is fed by TestTimeout (= DefaultTimeout), not the test's [CancelAfter(30000)]. PR #11380 bumped per-test [CancelAfter] values but missed this internal one; aligning the default with that fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @LukaszRozmej's task in 1m 18s —— View job Review
Change: The fix is correct and well-targeted. The root cause is clear: Side effects verified:
No issues found. The change is minimal, focused, and consistent with the intent of PR #11380. All known consumers of Verdict: approve. |
Summary
executePayloadV1_accepts_already_known_block(true)flakes onTEST_USE_FLAT=1runs withTaskCanceledExceptionat exactly 10s 489ms, insideTestBlockchain.Build()while waiting for theNewHeadBlockevent after genesis loads.this.CancellationToken, which derives fromTestTimeout(default10000), not the test's[CancelAfter(30000)].[CancelAfter]values from 10s/5s to 30s but missed this internal one. AligningDefaultTimeoutwith that fix.Stack from the failing run:
Side effects of the bump:
BlockProcessorTests.cs:146usesDefaultTimeout * 10— 100s ceiling becomes 300s. Just a higher upper bound; passing tests don't notice.TestRpcBlockchain.cs:72uses it as a fallback when no explicit timeout is passed.Test plan
Nethermind.Merge.Plugin.Test.🤖 Generated with Claude Code