Move unit tests to the location Meson expects them to be - #11708
Merged
Conversation
Ericson2314
requested review from
edolstra and
fricklerhandwerk
as code owners
October 16, 2024 19:22
Ericson2314
force-pushed
the
move-tests
branch
from
October 16, 2024 20:24
eedc0b2 to
8b2fb38
Compare
Member
|
For consistency, maybe it should be |
Ericson2314
force-pushed
the
move-tests
branch
from
October 17, 2024 19:34
8b2fb38 to
a708d62
Compare
Member
Author
|
OK, did that. |
Ericson2314
enabled auto-merge
October 17, 2024 19:34
Everything that is a separate subproject should live in the subprojects directory. Progress on NixOS#2503 This reverts commit 451f8a8.
Ericson2314
force-pushed
the
move-tests
branch
from
October 17, 2024 19:42
a708d62 to
e65510d
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-10-16-nix-team-meeting-minutes-187/54835/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Everything that is a separate subproject should live in the subprojects directory.
Context
Progress on #2503
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.