Skip to content

Move unit tests to the location Meson expects them to be - #11708

Merged
Ericson2314 merged 1 commit into
NixOS:masterfrom
obsidiansystems:move-tests
Oct 17, 2024
Merged

Move unit tests to the location Meson expects them to be#11708
Ericson2314 merged 1 commit into
NixOS:masterfrom
obsidiansystems:move-tests

Conversation

@Ericson2314

Copy link
Copy Markdown
Member

Motivation

Everything that is a separate subproject should live in the subprojects directory.

Context

Progress on #2503

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions Bot added documentation contributor-experience Developer experience for Nix contributors with-tests Issues related to testing. PRs with tests have some priority labels Oct 16, 2024
@Ericson2314 Ericson2314 changed the title Move tests to the location Meson expects Move functional tests to subproject dir Oct 16, 2024
@Ericson2314 Ericson2314 changed the title Move functional tests to subproject dir Move unit tests to the location Meson expects them to be Oct 16, 2024
@edolstra

edolstra commented Oct 17, 2024

Copy link
Copy Markdown
Member

For consistency, maybe it should be libexpr-tests instead of nix-expr-tests (etc.)? That would make it easier to see that each lib* directory has a corresponding test directory.

@Ericson2314

Copy link
Copy Markdown
Member Author

OK, did that.

@Ericson2314
Ericson2314 enabled auto-merge October 17, 2024 19:34
Everything that is a separate subproject should live in the subprojects
directory.

Progress on NixOS#2503

This reverts commit 451f8a8.
@Ericson2314
Ericson2314 merged commit 694c378 into NixOS:master Oct 17, 2024
@Ericson2314
Ericson2314 deleted the move-tests branch October 17, 2024 20:32
@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-10-16-nix-team-meeting-minutes-187/54835/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor-experience Developer experience for Nix contributors documentation with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants