-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
local-derivation-goal: improve "illegal reference" error (backport #12105) #12752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change "illegal reference" was hard to interpret as it did
not mention what derivation actually hits it.
Today's `nixpkgs` example:
Before the change:
$ nix build --no-link -f. postgresql_14
...
error: derivation contains an illegal reference specifier 'man'
After the change:
$ nix build --no-link -f. postgresql_14
...
error: derivation '/nix/store/bxp6g57limvwiga61vdlyvhy7i8rp6wd-postgresql-14.15.drv' output check for 'lib' contains an illegal reference specifier 'man', expected store path or output name (one of [debug, dev, doc, lib, out])
(cherry picked from commit bbdc319)
Contributor
Author
|
Cherry-pick of f3dbaa3 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
edolstra
reviewed
Mar 26, 2025
(cherry picked from commit f3dbaa3) # Conflicts: # src/libutil-tests/strings.cc # src/libutil/strings.hh
(cherry picked from commit 32898dc)
(cherry picked from commit 2b4d461)
(cherry picked from commit f4def47)
Otherwise without the change the test fails on nix-2.26 as:
error: derivation contains an illegal reference specifier 'dev'
Note: the error message does not match intended change.
(cherry picked from commit 1e7c724)
(cherry picked from commit 4d72e0f)
d22a869 to
cdf4bcc
Compare
Member
|
We can merge this if someone wants to fix the backport. Closing this otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automatic backport
This PR is a backport produced by automation (does not trigger backporting)
conflicts
merge-queue
with-tests
Issues related to testing. PRs with tests have some priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before the change "illegal reference" was hard to interpret as it did not mention what derivation actually hits it.
Today's
nixpkgsexample:Before the change:
After the change:
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #12105 done by [Mergify](https://mergify.com).