Bundle of fixes - #15716
Merged
Merged
Conversation
It was only printing the base name, which isn't how we usually print store paths.
mountInput modifies lockedRef.input to stuff narHash into it.
…d::function One slight blemish I noticed while touching this code. With C++23 we can simplify things.
Turns out the readOnlyMode was always dangling in the C API and nobody noticed... Previous commits just started accessing it, which was caught by ASan. This is the minimal fix I can think of.
This is necessary for making flake store paths lazier and also slightly more concise anyway.
github-actions
Bot
added
new-cli
This is thankfully not used by anything else anymore. Good riddance, since all usages of it had bugs in them.
Eveeifyeve
approved these changes
Apr 20, 2026
Mic92
enabled auto-merge
April 20, 2026 19:29
Mic92
approved these changes
Apr 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pulled out from #15711. Should be good to go without waiting for the changes from that PR.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.