Remove non-atomically initialised variable vImportedDrvToDerivation - #15889
Merged
Conversation
roberth
approved these changes
May 20, 2026
| **state.vImportedDrvToDerivation); | ||
| } | ||
| auto vImportedDrvToDerivation = state.allocValue(); | ||
| state.evalFile(state.importedDrvToDerivation, *vImportedDrvToDerivation); // has caching |
Member
There was a problem hiding this comment.
Suggested change
| state.evalFile(state.importedDrvToDerivation, *vImportedDrvToDerivation); // has caching | |
| state.evalFile(state.importedDrvToDerivation, *vImportedDrvToDerivation); |
Prone to rot, easy to check, not even frequently called, but thanks for checking!
Contributor
There was a problem hiding this comment.
I have a feeling @roberth was referring to the "import derivation" feature and it was meant as the top-level comment.
Member
There was a problem hiding this comment.
That was in reference to my suggestion to remove // has caching.
I see it's merged now, so let's just move on.
xokdvium
approved these changes
May 20, 2026
xokdvium
left a comment
xokdvium
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Unobservable change that reuses the same "to be implemented upstream" thunk locking idea.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes DeterminateSystems#447. (Only an issue with parallel eval which we don't have yet, but may as well fix it now.)
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.