Skip to content

libfprint-2-tod1-goodix-550a: init at 0.0.9 - #226056

Merged
SuperSandro2000 merged 2 commits into
NixOS:masterfrom
utkarshgupta137:master
Apr 30, 2023
Merged

libfprint-2-tod1-goodix-550a: init at 0.0.9#226056
SuperSandro2000 merged 2 commits into
NixOS:masterfrom
utkarshgupta137:master

Conversation

@utkarshgupta137

Copy link
Copy Markdown
Contributor
Description of changes

Added the driver for Goodix 27c6::550a fingerprint reader, provided by Lenovo.
Even though the driver is provided "only" for Thinkpad laptops, it is working perfectly fine on my Lenovo Legion (16ARHA7).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Comment on lines 15 to 16

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use fetchzip?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread pkgs/development/libraries/libfprint-2-tod1-goodix-550a/default.nix Outdated
@ofborg ofborg Bot added the 8.has: package (new) This PR adds a new package label Apr 16, 2023
@ofborg
ofborg Bot requested a review from grahamc April 16, 2023 01:16
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 16, 2023
@SuperSandro2000
SuperSandro2000 merged commit 1f78735 into NixOS:master Apr 30, 2023
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants