protonvpn-gui: 4.7.4 -> 4.8.0 - #359877
Merged
Merged
Conversation
Update the package to the latest version.
Steinhagen
marked this pull request as draft
November 28, 2024 15:51
github-actions
Bot
added
the
6.topic: python
Contributor
Author
|
I will leave this PR in draft until I can properly verify all functions. |
Steinhagen
marked this pull request as ready for review
November 29, 2024 07:43
ofborg
Bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
Everything seems to work fine with this update. Probably all dependencies of ProtonVPN should be verified if they are correctly working on other non-x86 platforms. |
Update the package to the latest version and restrict the platforms only to Linux. Officially there isn't any indication that this should be supported by anything else other than Linux and our current builds are failing for Darwin.
Update the package to the latest version.
Update the package to the latest version.
Update the package to the latest version. iproute2 dependency is a Linux only package so this will not be available for anything else either. Also, based on the official documentation, there isn't any indication that other platforms other than Linux is supported.
Update the package to the latest version.
Steinhagen
force-pushed
the
proton-update-4-8
branch
from
November 29, 2024 19:41
86ec030 to
f11e9d4
Compare
Contributor
Author
|
I've added the correct platforms for proton-vpn-network-manager and proton-vpn-api-core. |
ofborg
Bot
added
the
8.has: clean-up
Contributor
|
SebTM
approved these changes
Dec 3, 2024
SebTM
left a comment
SebTM
left a comment
Contributor
There was a problem hiding this comment.
Tested against nixos-unstable, main-app, settings/about window and wireguard-connection are still working properly for me
SebTM
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update protonvpn-gui and all it's dependencies to the latest released version.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.