Skip to content

postgis: add sfcgal support #366650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ma27 merged 1 commit into from
Jan 17, 2025
Merged

postgis: add sfcgal support #366650

Ma27 merged 1 commit into from
Jan 17, 2025

Conversation

@autra
Copy link
Contributor

@autra autra commented Dec 19, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 19, 2024
@autra
Copy link
Contributor Author

autra commented Dec 19, 2024 •
edited
Loading

Depends on #366648

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 19, 2024
@autra
Copy link
Contributor Author

autra commented Dec 19, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366650

x86_64-linux

✅ 1 package built:
  • sfcgal

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 20, 2024
@autra autra self-assigned this Jan 2, 2025
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 2, 2025
@autra autra marked this pull request as ready for review January 16, 2025 21:05
wolfgangwalther
wolfgangwalther reviewed Jan 16, 2025
View reviewed changes
@autra
Copy link
Contributor Author

autra commented Jan 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366650

@github-actions github-actions bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 16, 2025
@autra
Copy link
Contributor Author

autra commented Jan 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366650

x86_64-linux

@autra
Copy link
Contributor Author

autra commented Jan 17, 2025

@NixOS/geospatial please review :-)

Ma27
Ma27 reviewed Jan 17, 2025
View reviewed changes
@Ma27 Ma27 merged commit 7442b7f into NixOS:master Jan 17, 2025
24 of 27 checks passed
@autra autra mentioned this pull request Jan 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 approved these changes

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@imincik imincik Awaiting requested review from imincik

@fqidz fqidz Awaiting requested review from fqidz

@sikmir sikmir Awaiting requested review from sikmir

@willcohen willcohen Awaiting requested review from willcohen

@l0b0 l0b0 Awaiting requested review from l0b0

@nh2 nh2 Awaiting requested review from nh2

@nialov nialov Awaiting requested review from nialov

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

@autra autra

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@autra @Ma27 @wolfgangwalther