-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
fim: fix cross / strictDeps build #370553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
uninsane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't tried building it, but aside from the patch substitution the rest LGTM
95035fd to
d77e6ab
Compare
|
new version breaks native compilation. error message suggests to use |
d77e6ab to
6a58e26
Compare
|
Fixed. Bit of a silly check since uppercase variables can't be substituted anyway #28086 |
native build has png support: would ideally also have png support when cross compiling (or at the very least, change up the |
6a58e26 to
ff98dd6
Compare
|
Since we switched SDL to SDL_compat -> sdl2-compat -> sdl3 -> ... -> Qt, x11Support now defaults to false for cross. libpng fixed. |
needs its shebang fixed |
|
also, cross is building without ascii art support: can likely be fixed the same way png was fixed. other than that i think it's correct. |
ff98dd6 to
06f6e78
Compare
|
Fixed, and I've now just compared the build logs, as I should have perhaps done from the start. And found two more things that differed, fixed via configureFlags. |
ref. #178468
Things done