postgresqlTestHook: shutdown on failure#389938
Merged
wolfgangwalther merged 3 commits intoNixOS:masterfrom May 11, 2025
Merged
Conversation
github-actions
bot
added
6.topic: python
wolfgangwalther
force-pushed
the
postgresql-test-hook
branch
2 times, most recently
from
130a3f6 to
96263a2
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
wolfgangwalther
force-pushed
the
postgresql-test-hook
branch
2 times, most recently
from
f984365 to
beff5a9
Compare
Contributor
Author
|
nix-owners
bot
requested review from
infinisil,
maralorn,
philiptaron,
sternenseemann and
thoughtpolice
wolfgangwalther
force-pushed
the
postgresql-test-hook
branch
from
beff5a9 to
a375e25
Compare
roberth
previously requested changes
Mar 23, 2025
Member
There was a problem hiding this comment.
I'm sympathetic to the cause, and I will support this workaround, but ultimately we should fix these kinds of problems with more granular builds, where tests run in separate derivations, reusing previous builds.
For the current solution, I have these requests:
- rename
postgresqlForTestingtopostgresqlForNixpkgsInternalTesting- out-of-tree users should use the normal postgres (otherwise, we make them test with a version that's not the default version they may use in production)
- avoid input propagation so that users can pick the right postgresql version. Hiding this dependency creates extra complexity and problems:
- unclear which postgres is used
- need to learn about the hook before someone can change the postgres version
- (possibly?) conflict between the propagated postgres and the directly provided postgres
Contributor
Author
|
Given that this only triggered ~180 rebuilds, it won't be enough on its own to reduce the number of rebuilds for PostgreSQL to allow direct updates to master, yet. Putting this on draft, until:
|
7 tasks
wegank
added
the
2.status: merge conflict
Merged
10 tasks
Contributor
Author
|
In #404572, we merged the last set of minor updates for PostgreSQL straight into master. Thus, for now, we don't need this anymore. |
Contributor
Author
|
Ah, not true: There is more in here than just the |
wolfgangwalther
changed the title
wolfgangwalther
force-pushed
the
postgresql-test-hook
branch
from
a375e25 to
805bec8
Compare
github-actions
bot
removed
6.topic: python
Thanks, deadnix.
Previously, the user of postgresqlTestHook would have needed to set failureHook accordingly. However, this was not a clean solution, because postgresqlStop would also run for configure or build failures, before the server was even started. This gave odd errors from a failed shutdown in the log. Now postgresqlStop is only called when it makes sense - and whenever postgresqlTestHook is used.
wolfgangwalther
force-pushed
the
postgresql-test-hook
branch
from
805bec8 to
065fefd
Compare
ofborg
bot
removed
the
2.status: merge conflict
github-actions
bot
added
10.rebuild-darwin: 11-100
nix-owners
bot
requested review from
MarcWeber,
autra,
imincik,
l0b0,
nh2,
nialov,
sikmir and
willcohen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves postgresqlTestHook in two aspects:One is, that postgresql doesn't need to be added manually to everynativeCheckInputs list anymore.
The other is, that all those tests now run with a specially pinnedPostgreSQL version, which can be updated independently via staging.
This allows us to ship updates to PostgreSQL faster by going to masterdirectly. In the normal case, the latest version and the test version
evaluate to the exact same derivation, so no duplicate builds. Only
while a minor update for the test version is going through staging, the
two versions differ temporarily.
Change of plans: Only some small improvements to
postgresqlTestHookleft.Things done
Hopefully the number of rebuilds is low enough for master 🤔
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.