Closed
Conversation
github-actions
bot
added
the
8.has: maintainer-list (update)
Contributor
Author
|
github-actions
bot
added
10.rebuild-darwin: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5327 |
mweinelt
requested changes
Apr 29, 2025
Member
There was a problem hiding this comment.
Drop this change and rebase, octodns supports autocalling its providers since #402602.
Member
|
@anthonyroussel Please set up code ownership for the whole octodns directory, since you apparently did not get pinged for this PR. |
13 tasks
| homepage = "https://github.com/octodns/octodns-ovh/"; | ||
| changelog = "https://github.com/octodns/octodns-ovh/blob/${version}/CHANGELOG.md"; | ||
| license = lib.licenses.mit; | ||
| maintainers = with lib.maintainers; [ nifoc ]; |
Member
There was a problem hiding this comment.
Suggested change
| maintainers = with lib.maintainers; [ nifoc ]; | |
| maintainers = with lib.maintainers; [ nifoc ]; | |
| teams = [ lib.teams.octodns ]; |
Could you please add octodns to meta.teams?
wegank
added
the
2.status: merge conflict
13 tasks
Member
|
Updated to v1.1.0 and solved merge conflicts, here: #427843 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add octodns-ovh as an octoDNS provider.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.