Skip to content

Comments

{polarity,pomsky,rust-synapse-compress-state,syncstorage-rs}: use fetchCargoVendor#392758

Merged
JohnRTitor merged 4 commits intoNixOS:masterfrom
TomaSajt:cargo-lockfile-cleaning-prs
Mar 25, 2025
Merged

{polarity,pomsky,rust-synapse-compress-state,syncstorage-rs}: use fetchCargoVendor#392758
JohnRTitor merged 4 commits intoNixOS:masterfrom
TomaSajt:cargo-lockfile-cleaning-prs

Conversation

@TomaSajt
Copy link
Contributor

This PR migrates a few packages to use fetchCargoVendor.

There have been previous attempts at migrating larger chunks of packages, but I believe smaller chunks are more reviewable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025
@nix-owners nix-owners bot requested review from figsoda, maralorn and mweinelt March 24, 2025 16:16
@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392758

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/14051392768


x86_64-linux

✅ 4 packages built:
  • polarity
  • pomsky
  • rust-synapse-compress-state
  • syncstorage-rs

aarch64-linux

✅ 4 packages built:
  • polarity
  • pomsky
  • rust-synapse-compress-state
  • syncstorage-rs

x86_64-darwin

⏩ 1 package marked as broken and skipped:
  • rust-synapse-compress-state
✅ 2 packages built:
  • polarity
  • pomsky

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • rust-synapse-compress-state
✅ 2 packages built:
  • polarity
  • pomsky

@JohnRTitor
Copy link
Member

Merging, as this a simple non breaking change.

@JohnRTitor JohnRTitor merged commit 0a23e92 into NixOS:master Mar 25, 2025
26 of 27 checks passed
@TomaSajt TomaSajt deleted the cargo-lockfile-cleaning-prs branch April 24, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants