shell.nix: include gh in the default shell#392828
Conversation
GitHub's CLI is now used by nixpkgs-review to fetch Nixpkgs evaluation results from GitHub Actions. Including it in the default shell will allow all contributors to easily log-in to GitHub when nixpkgs-review tries to fetch evaluation results. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
|
Relevant bit: https://github.com/Mic92/nixpkgs-review/blob/df034b59d756e80d30532d0756809d4536307098/nixpkgs_review/cli/pr.py#L48-L56 Technically, should still be usable... should just fallback to the old behavior of always evaluating locally. But, is a better experience (much better) with using the results from CI. |
|
Also, some users simply cannot run the local evaluation at all, due to memory constraints. Using GitHub Actions' evaluation should lower the barrier of entry for contributors with lower-end machines. |
True, I used to |
|
Sounds like a good addition to me. |
GitHub's CLI is now used by
nixpkgs-reviewto fetch Nixpkgs evaluation results from GitHub Actions. Including it in the default shell will allow all contributors to easily log-in to GitHub when nixpkgs-review tries to fetch evaluation results.Spawned from a small discussion in the
devmatrix channel about adding a Justfile to Nixpkgs. Adding justghto the shell for now should be considerably less controversial.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.