Skip to content

Conversation

@Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Apr 8, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 8, 2025
@nix-owners nix-owners bot requested a review from natsukium April 8, 2025 15:31
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 8, 2025
@Guelakais Guelakais force-pushed the colcon-argcomplete branch 2 times, most recently from 30136ec to 36f88e5 Compare April 9, 2025 07:15
@Guelakais Guelakais force-pushed the colcon-argcomplete branch from 36f88e5 to bdd25ff Compare April 16, 2025 19:10
@Guelakais Guelakais force-pushed the colcon-argcomplete branch from bdd25ff to b7a11b9 Compare April 21, 2025 19:42
@Guelakais Guelakais requested a review from mweinelt April 21, 2025 19:42
@Guelakais Guelakais force-pushed the colcon-argcomplete branch from b7a11b9 to dfd66c0 Compare April 21, 2025 20:31
@Guelakais Guelakais requested a review from mweinelt April 21, 2025 20:32
@Guelakais Guelakais force-pushed the colcon-argcomplete branch from dfd66c0 to 7ebc598 Compare April 21, 2025 20:47
@mweinelt mweinelt merged commit 402991e into NixOS:master Apr 21, 2025
24 of 27 checks passed
@Guelakais Guelakais moved this to ✅ Done in ROS 2 Apr 24, 2025
@Guelakais Guelakais added this to ROS 2 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants