Skip to content

Conversation

@afh
Copy link
Member

@afh afh commented Apr 11, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 11, 2025
@nix-owners nix-owners bot requested a review from majiru April 11, 2025 19:48
@afh afh force-pushed the init-drawterm-cocoa branch from 8e7a86a to 399c9e5 Compare April 11, 2025 20:03
@afh afh changed the title drawterm-cocoa: init at 0-unstable-2025-03-18 drawterm: migrate to by-name; drawterm-cocoa: init at 0-unstable-2025-03-18 Apr 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 12, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 17, 2025
@afh afh force-pushed the init-drawterm-cocoa branch from 6dc2433 to aabb4c5 Compare April 17, 2025 10:11
@afh
Copy link
Member Author

afh commented Apr 17, 2025

Thanks for the review, the helpful suggestions—which I've applied to this PR—and the approval, @Aleksanaa; all much appreciated 🙂

@Aleksanaa
Copy link
Member

@ofborg build drawterm drawterm-wayland

@afh afh changed the title drawterm: migrate to by-name; drawterm-cocoa: init at 0-unstable-2025-03-18 drawterm: migrate to by-name; add darwin platform Apr 18, 2025
@Aleksanaa
Copy link
Member

nixos test failed on darwin, which isn't something to worry about

@Aleksanaa Aleksanaa merged commit 1583907 into NixOS:master Apr 20, 2025
39 checks passed
@afh afh deleted the init-drawterm-cocoa branch May 18, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants