nixos/nextcloud: S3: Rename autocreate (a no-op) to verify_bucket_exists #399629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
herbetom
requested review from
Ma27,
bachp,
britter,
dotlambda and
provokateurin
C.f. nextcloud/documentation#10436 Co-authored-by: Tom Herbers <mail@tomherbers.de> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
herbetom
force-pushed
the
fix-nextcloud-s3-verify_bucket_exists
branch
from
7f56fc4 to
08e859c
Compare
provokateurin
approved these changes
Apr 19, 2025
wegank
added
the
12.approvals: 1
Ma27
approved these changes
Apr 22, 2025
Contributor
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #275165 but rebased.
The
autocreateoption always was a no-op in nextcloud: nextcloud/documentation#10436A bit of info for
verify_bucket_existscan be found in the nextcloud docs:Source: https://docs.nextcloud.com/server/31/admin_manual/configuration_files/primary_storage.html#configuration
Also the Code isn't really complicated:
https://github.com/nextcloud/server/blob/c3370204463f2be4c053c384d220ded79917481b/lib/private/Files/ObjectStore/S3ConnectionTrait.php#L132-L149
It checks wheter the bucket exists and if not the bucket is created.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.