Skip to content

treewide: remove uses of deprecated Darwin overrideSDK #400398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilazy merged 3 commits into from
Apr 20, 2025
Merged

treewide: remove uses of deprecated Darwin overrideSDK #400398

emilazy merged 3 commits into from
Apr 20, 2025

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Apr 20, 2025

Tidying up for 25.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: stdenv Standard environment 6.topic: php PHP is a general-purpose scripting language geared towards web development. labels Apr 20, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 20, 2025
@nix-owners nix-owners bot requested review from Cryolitia and luizirber April 20, 2025 21:55
khaneliman
khaneliman approved these changes Apr 20, 2025
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this to In Progress in Stdenv Apr 20, 2025
Cryolitia
Cryolitia approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilazy emilazy merged commit 6e0a16c into NixOS:staging Apr 20, 2025
24 of 28 checks passed
@emilazy emilazy deleted the push-ksuwxvqmkmxu branch April 20, 2025 23:05
@github-project-automation github-project-automation bot moved this from In Progress to Done in Stdenv Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaneliman khaneliman khaneliman approved these changes

@luizirber luizirber Awaiting requested review from luizirber

+1 more reviewer

@Cryolitia Cryolitia Cryolitia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Stdenv
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emilazy @khaneliman @Cryolitia