Skip to content

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Apr 22, 2025

Backport of #400781

This prevent Gnome to find the app correctly.

(cherry-picked from 9de6d91)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This prevent Gnome to find the app correctly.

(cherry-picked from 9de6d91)
@drupol drupol requested a review from JohnRTitor April 22, 2025 10:15
@nix-owners nix-owners bot requested a review from mweinelt April 22, 2025 10:17
@drupol drupol changed the title firefox: do not set the executable bit on desktop file [Backport release-24.11] firefox: do not set the executable bit on desktop file Apr 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@drupol drupol merged commit b1ef14f into NixOS:release-24.11 Apr 22, 2025
40 of 43 checks passed
@drupol drupol deleted the backport-400781-to-release-24.11 branch April 22, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant