-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
nodejs_20: 20.19.0 -> 20.19.1 #400828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs_20: 20.19.0 -> 20.19.1 #400828
Conversation
|
I'm unable to build any of those on aarch64-darwin, I suspect they've been broken for a while: $ hydra-check actual-server --arch aarch64-darwin
Build Status for actual-server.aarch64-darwin on jobset nixpkgs/trunk
https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin
✖ (Failed) actual-server-25.4.0 2025-04-23 https://hydra.nixos.org/build/295394395
✔ actual-server-25.3.1 2025-04-19 https://hydra.nixos.org/build/294710073
✔ actual-server-25.3.1 2025-03-23 https://hydra.nixos.org/build/293124879
✔ actual-server-25.3.1 2025-03-17 https://hydra.nixos.org/build/292792069
✔ actual-server-25.3.1 2025-03-13 https://hydra.nixos.org/build/292039198
✔ actual-server-25.3.1 2025-03-10 https://hydra.nixos.org/build/292016696
✔ actual-server-25.1.0 2025-02-21 https://hydra.nixos.org/build/290318132
✔ actual-server-25.1.0 2025-02-11 https://hydra.nixos.org/build/288776276
✔ actual-server-25.1.0 2025-02-06 https://hydra.nixos.org/build/287941542
✔ actual-server-25.1.0 2025-01-31 https://hydra.nixos.org/build/287408866
Links:
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin/all (all builds)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin/latest (latest successful build)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin/latest-finished (latest success from a finished eval)
info: showing inputs for the latest success from a finished eval...
input: nixpkgs
type: Git checkout
value: https://github.com/nixos/nixpkgs.git
revision: bbcdf758d61b6095693d00dea8a75061bf89b264
store_path: /nix/store/myd1xs6dfcw5sgy7b849hgxdc5yfrj6k-source
input: officialRelease
type: Boolean
value: false
$ hydra-check bitwarden-cli --arch aarch64-darwin
Build Status for bitwarden-cli.aarch64-darwin on jobset nixpkgs/trunk
https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin
✖ (Failed) bitwarden-cli-2025.3.0 2025-04-19 https://hydra.nixos.org/build/294718663
✖ (Failed) bitwarden-cli-2025.3.0 2025-04-11 https://hydra.nixos.org/build/294646683
✖ (Failed) bitwarden-cli-2025.2.0 2025-04-03 https://hydra.nixos.org/build/293131984
✖ (Failed) bitwarden-cli-2025.2.0 2025-03-20 https://hydra.nixos.org/build/292904805
✔ bitwarden-cli-2025.2.0 2025-03-17 https://hydra.nixos.org/build/292792123
⏹ (Cancelled) bitwarden-cli-2025.2.0 2025-03-17 https://hydra.nixos.org/build/292781900
✔ bitwarden-cli-2025.1.3 2025-03-11 https://hydra.nixos.org/build/292046319
✔ bitwarden-cli-2025.1.3 2025-02-22 https://hydra.nixos.org/build/290788483
✔ bitwarden-cli-2025.1.2 2025-02-20 https://hydra.nixos.org/build/290325159
✔ bitwarden-cli-2025.1.2 2025-02-11 https://hydra.nixos.org/build/288777353
Links:
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin/all (all builds)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin/latest (latest successful build)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin/latest-finished (latest success from a finished eval)
info: showing inputs for the latest success from a finished eval...
input: nixpkgs
type: Git checkout
value: https://github.com/nixos/nixpkgs.git
revision: 5d9b5431f967007b3952c057fc92af49a4c5f3b2
store_path: /nix/store/g47hr2nd5w2chjpz8xs8krdwrbzfa3y1-source
input: officialRelease
type: Boolean
value: false |
dwt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, the change itself looks good, and as far as I can see the non broken packages seem to work.
FliegendeWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds. Changelog looks good
|
Successfully created backport PR for |
https://nodejs.org/en/blog/release/v20.19.1
I've added https://github.com/NixOS/nixpkgs/labels/backport%20staging-24%2E11 even though this PR targets
master, the reason being that 24.11 did not get #333210, and update Node.js 20 produces mass rebuilds on 24.11.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.