Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 22, 2025

https://nodejs.org/en/blog/release/v20.19.1

I've added https://github.com/NixOS/nixpkgs/labels/backport%20staging-24%2E11 even though this PR targets master, the reason being that 24.11 did not get #333210, and update Node.js 20 produces mass rebuilds on 24.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 22, 2025
@aduh95 aduh95 added backport staging-24.11 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Apr 23, 2025
@dwt dwt mentioned this pull request Apr 27, 2025
3 tasks
@dwt
Copy link
Contributor

dwt commented Apr 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400828


aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • paperless-ngx
  • paperless-ngx.dist
❌ 2 packages failed to build:
  • actual-server
  • bitwarden-cli
✅ 27 packages built:
  • balena-cli
  • bitwarden-desktop
  • corepack_20
  • dashy-ui
  • devcontainer
  • ethercalc
  • github-runner
  • httptoolkit
  • httptoolkit-server
  • isso
  • isso.dist
  • isso.doc
  • jellyfin
  • jellyfin-media-player
  • jellyfin-web
  • math-preview
  • netlify-cli
  • nodejs-slim_20
  • nodejs-slim_20.dev
  • nodejs-slim_20.libv8
  • nodejs_20
  • nodejs_20.dev
  • nodejs_20.libv8
  • rqbit
  • snyk
  • tandoor-recipes
  • whitebophir

Only two failures, is that good?

@aduh95
Copy link
Contributor Author

aduh95 commented Apr 27, 2025

packages failed to build:

  • actual-server
  • bitwarden-cli

I'm unable to build any of those on aarch64-darwin, I suspect they've been broken for a while:

$ hydra-check actual-server --arch aarch64-darwin
Build Status for actual-server.aarch64-darwin on jobset nixpkgs/trunk
https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin
✖ (Failed)  actual-server-25.4.0  2025-04-23  https://hydra.nixos.org/build/295394395
✔           actual-server-25.3.1  2025-04-19  https://hydra.nixos.org/build/294710073
✔           actual-server-25.3.1  2025-03-23  https://hydra.nixos.org/build/293124879
✔           actual-server-25.3.1  2025-03-17  https://hydra.nixos.org/build/292792069
✔           actual-server-25.3.1  2025-03-13  https://hydra.nixos.org/build/292039198
✔           actual-server-25.3.1  2025-03-10  https://hydra.nixos.org/build/292016696
✔           actual-server-25.1.0  2025-02-21  https://hydra.nixos.org/build/290318132
✔           actual-server-25.1.0  2025-02-11  https://hydra.nixos.org/build/288776276
✔           actual-server-25.1.0  2025-02-06  https://hydra.nixos.org/build/287941542
✔           actual-server-25.1.0  2025-01-31  https://hydra.nixos.org/build/287408866

Links:
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin/all (all builds)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin/latest (latest successful build)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/actual-server.aarch64-darwin/latest-finished (latest success from a finished eval)

info: showing inputs for the latest success from a finished eval...

input: nixpkgs
type: Git checkout
value: https://github.com/nixos/nixpkgs.git
revision: bbcdf758d61b6095693d00dea8a75061bf89b264
store_path: /nix/store/myd1xs6dfcw5sgy7b849hgxdc5yfrj6k-source

input: officialRelease
type: Boolean
value: false
$ hydra-check bitwarden-cli --arch aarch64-darwin
Build Status for bitwarden-cli.aarch64-darwin on jobset nixpkgs/trunk
https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin
✖ (Failed)     bitwarden-cli-2025.3.0  2025-04-19  https://hydra.nixos.org/build/294718663
✖ (Failed)     bitwarden-cli-2025.3.0  2025-04-11  https://hydra.nixos.org/build/294646683
✖ (Failed)     bitwarden-cli-2025.2.0  2025-04-03  https://hydra.nixos.org/build/293131984
✖ (Failed)     bitwarden-cli-2025.2.0  2025-03-20  https://hydra.nixos.org/build/292904805
✔              bitwarden-cli-2025.2.0  2025-03-17  https://hydra.nixos.org/build/292792123
⏹ (Cancelled)  bitwarden-cli-2025.2.0  2025-03-17  https://hydra.nixos.org/build/292781900
✔              bitwarden-cli-2025.1.3  2025-03-11  https://hydra.nixos.org/build/292046319
✔              bitwarden-cli-2025.1.3  2025-02-22  https://hydra.nixos.org/build/290788483
✔              bitwarden-cli-2025.1.2  2025-02-20  https://hydra.nixos.org/build/290325159
✔              bitwarden-cli-2025.1.2  2025-02-11  https://hydra.nixos.org/build/288777353

Links:
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin/all (all builds)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin/latest (latest successful build)
🔗 https://hydra.nixos.org/job/nixpkgs/trunk/bitwarden-cli.aarch64-darwin/latest-finished (latest success from a finished eval)

info: showing inputs for the latest success from a finished eval...

input: nixpkgs
type: Git checkout
value: https://github.com/nixos/nixpkgs.git
revision: 5d9b5431f967007b3952c057fc92af49a4c5f3b2
store_path: /nix/store/g47hr2nd5w2chjpz8xs8krdwrbzfa3y1-source

input: officialRelease
type: Boolean
value: false

Copy link
Contributor

@dwt dwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, the change itself looks good, and as far as I can see the non broken packages seem to work.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 28, 2025
@aduh95 aduh95 requested a review from FliegendeWurst May 9, 2025 12:06
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds. Changelog looks good

@FliegendeWurst FliegendeWurst merged commit 030d1d5 into NixOS:master May 10, 2025
39 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 10, 2025

Successfully created backport PR for staging-24.11:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 10, 2025
@aduh95 aduh95 deleted the nodejs-20 branch May 10, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants