nixos/logrotate: Copy configFile to /etc, remove option#512581
Open
m1cr0man wants to merge 1 commit intoNixOS:masterfrom
Open
nixos/logrotate: Copy configFile to /etc, remove option#512581m1cr0man wants to merge 1 commit intoNixOS:masterfrom
m1cr0man wants to merge 1 commit intoNixOS:masterfrom
Conversation
Izorkin
reviewed
Apr 25, 2026
m1cr0man
force-pushed
the
rfc108-logrotate
branch
from
ff1c677 to
becb48b
Compare
m1cr0man
changed the title
Izorkin
reviewed
Apr 26, 2026
m1cr0man
force-pushed
the
rfc108-logrotate
branch
from
becb48b to
f20bd58
Compare
Izorkin
approved these changes
Apr 26, 2026
nixpkgs-ci
Bot
added
the
12.approvals: 1
When running logrotate in a user namespaced environment, such as an nspawn container with PrivateUsers=pick, logrotate may refuse to start as its config file is not owned by root. Using environment.etc we can copy the file from the store and set the proper permissions during activation. As such, there is much less utility in being able to configure the configFile path now, and `include` directives supported in the program's own config schema would suffice for including extra config outside of the NixOS module.
m1cr0man
force-pushed
the
rfc108-logrotate
branch
from
f20bd58 to
82a28d1
Compare
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
After rebasing on master with #512584 merged, the CI checks are now passing 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of breaking up #216025
When running logrotate in a user namespaced environment, such as an nspawn container with PrivateUsers=pick, logrotate may refuse to start as its config file is not owned by root.
Using environment.etc we can copy the file from the store and set the proper permissions during activation.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.