New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize waypoints set by the player #2598

Open
Mailaender opened this Issue Jan 17, 2013 · 21 comments

Comments

Projects
None yet
@Mailaender
Member

Mailaender commented Jan 17, 2013

You can currently use Shift + Click to set waypoints for your units. There should be a flag (suggesting the one from the rally point) to visualize this.

@chrisforbes

This comment has been minimized.

Show comment
Hide comment
@chrisforbes

chrisforbes Jan 18, 2013

Member

Do we want to eventually support waypoints when setting rallypoints, too?

On Fri, Jan 18, 2013 at 12:41 PM, Matthias Mailänder <
notifications@github.com> wrote:

You can currently use Shift + Click to set waypoints for your units. There
should be a flag (suggesting the one from the rally point) to visualize
this.


Reply to this email directly or view it on GitHubhttps://github.com/OpenRA/OpenRA/issues/2598.

Member

chrisforbes commented Jan 18, 2013

Do we want to eventually support waypoints when setting rallypoints, too?

On Fri, Jan 18, 2013 at 12:41 PM, Matthias Mailänder <
notifications@github.com> wrote:

You can currently use Shift + Click to set waypoints for your units. There
should be a flag (suggesting the one from the rally point) to visualize
this.


Reply to this email directly or view it on GitHubhttps://github.com/OpenRA/OpenRA/issues/2598.

@Generalcamo

This comment has been minimized.

Show comment
Hide comment
@Generalcamo

Generalcamo Jan 22, 2013

Contributor

That might be a good idea to implement. I'm all for it. (Both Mail and Chris)

Contributor

Generalcamo commented Jan 22, 2013

That might be a good idea to implement. I'm all for it. (Both Mail and Chris)

@Surrealistik

This comment has been minimized.

Show comment
Hide comment
@Surrealistik

Surrealistik Apr 4, 2013

+1 to both proposals.

Surrealistik commented Apr 4, 2013

+1 to both proposals.

@Snurre86

This comment has been minimized.

Show comment
Hide comment
@Snurre86

Snurre86 Jun 25, 2014

Here is an image of waypoints and the rallypoint for the "War Factory".
Illustration of waypoints
I also think the mouse cursor should be changed from a blue attack cursor to a flag when you are about to place a rallypoint for a building even if you hold "shift" or "z" to create waypoints to the rallypoint.
Illustration of waypoints

Snurre86 commented Jun 25, 2014

Here is an image of waypoints and the rallypoint for the "War Factory".
Illustration of waypoints
I also think the mouse cursor should be changed from a blue attack cursor to a flag when you are about to place a rallypoint for a building even if you hold "shift" or "z" to create waypoints to the rallypoint.
Illustration of waypoints

@Snurre86

This comment has been minimized.

Show comment
Hide comment
@Snurre86

Snurre86 Jun 25, 2014

If a sound is added to the activation of waypoints (when you press/let go of "shift" or "z") and a diffrent sound when a waypoint is placed (shift+mouse button or z+mouse button) it is going to be easyer for the brain.

Snurre86 commented Jun 25, 2014

If a sound is added to the activation of waypoints (when you press/let go of "shift" or "z") and a diffrent sound when a waypoint is placed (shift+mouse button or z+mouse button) it is going to be easyer for the brain.

@xan2622

This comment has been minimized.

Show comment
Hide comment
@xan2622

xan2622 Jun 22, 2015

Contributor

+1 for all these ideas.

Contributor

xan2622 commented Jun 22, 2015

+1 for all these ideas.

@Mailaender Mailaender added the UI label Jun 22, 2015

@orabot orabot changed the title from Visualize waypoints set by the player to Visualize waypoints set by the player [$5] Jun 28, 2015

@orabot orabot added the Bounty label Jun 28, 2015

@orabot orabot changed the title from Visualize waypoints set by the player [$5] to Visualize waypoints set by the player [$10] Jun 30, 2015

@orabot orabot changed the title from Visualize waypoints set by the player [$10] to Visualize waypoints set by the player [$25] Jul 3, 2015

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 3, 2015

I didn't think way-points were implemented in the game! This will ease microing significantly...

I assume the waypoint logic could be extended to make nicer visual scripting waypoints in the ingame map editor? (If done like RA2 with the solid line between points)

ghost commented Jul 3, 2015

I didn't think way-points were implemented in the game! This will ease microing significantly...

I assume the waypoint logic could be extended to make nicer visual scripting waypoints in the ingame map editor? (If done like RA2 with the solid line between points)

@reaperrr reaperrr referenced this issue Jul 7, 2015

Closed

Add TS features required for a full remake #7874

51 of 91 tasks complete

@orabot orabot changed the title from Visualize waypoints set by the player [$25] to Visualize waypoints set by the player [$50] Oct 10, 2015

@huwpascoe

This comment has been minimized.

Show comment
Hide comment
@huwpascoe

huwpascoe Nov 3, 2015

Contributor

I'm now taking on this issue.

Contributor

huwpascoe commented Nov 3, 2015

I'm now taking on this issue.

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn

Turupawn Aug 9, 2016

Member

Hey guys! I'm new here and I just started working on this issue.
So far I managed to visualize the waypoint lines.
I made a video showing my progress.

I'm currently working on this branch but I haven't made a Pull Request yet because the code is very messy. But I'll do so soon. Also, I'm waiting to get my other PR approved so I can understand better the workflow, see #11781

Is this thing still alive? What do you think about my progress?

Cheers!

Member

Turupawn commented Aug 9, 2016

Hey guys! I'm new here and I just started working on this issue.
So far I managed to visualize the waypoint lines.
I made a video showing my progress.

I'm currently working on this branch but I haven't made a Pull Request yet because the code is very messy. But I'll do so soon. Also, I'm waiting to get my other PR approved so I can understand better the workflow, see #11781

Is this thing still alive? What do you think about my progress?

Cheers!

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Aug 9, 2016

Member

I also tried my luck with it, but failed to achieve anything usable. Your progress looks good. 👍

Member

Mailaender commented Aug 9, 2016

I also tried my luck with it, but failed to achieve anything usable. Your progress looks good. 👍

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn

Turupawn Aug 9, 2016

Member

I'll keep working on it.
Thanks! <3

Member

Turupawn commented Aug 9, 2016

I'll keep working on it.
Thanks! <3

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 9, 2016

Member

I strongly suggest using the existing Activity.GetTargets code instead of rolling your own – it already works for all activities.

Member

pchote commented Aug 9, 2016

I strongly suggest using the existing Activity.GetTargets code instead of rolling your own – it already works for all activities.

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn

Turupawn Aug 9, 2016

Member

@pchote Sure! I'll do so 👌

Member

Turupawn commented Aug 9, 2016

@pchote Sure! I'll do so 👌

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn

Turupawn Aug 9, 2016

Member

BTW, Thanks for adding me to @OpenRA/bug-assignees. I don't know exactly what that means but I really apreciate it. 🌼

Member

Turupawn commented Aug 9, 2016

BTW, Thanks for adding me to @OpenRA/bug-assignees. I don't know exactly what that means but I really apreciate it. 🌼

@Mailaender Mailaender assigned Turupawn and unassigned huwpascoe Aug 9, 2016

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Aug 9, 2016

Member

You can now show others that you want to pick up a task.

Member

Mailaender commented Aug 9, 2016

You can now show others that you want to pick up a task.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Aug 9, 2016

Contributor

If you mean "letting issues assigned to yourself", then sorry to tell, but that never worked. Would have done that sometimes already by now if it would have.

Contributor

GraionDilach commented Aug 9, 2016

If you mean "letting issues assigned to yourself", then sorry to tell, but that never worked. Would have done that sometimes already by now if it would have.

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn
Member

Turupawn commented Aug 9, 2016

@Mailaender Cool!

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn

Turupawn Aug 15, 2016

Member

Hello again guys!
A quick update about my progress:

  • I just managed to make this work without rolling my own tech at #11794
  • I just made a short video that shows how they look now
  • @pchote: I didn't use Activity.GetTargets but GetDestination which is working just fine, what do you think about it?
  • I had to deal with the Activity Queue which was very painful. What is wrong with that Queue? Why does it is always losing the references? Maybe I'm missing something because I have never coded on C# for this long...
  • Now I want to simplify all this mess I just made so any code review overview would be a huge help at this point

Thanks again guys. This has been a looooong trip but I'm having a lot of fun and that's very important to me

Member

Turupawn commented Aug 15, 2016

Hello again guys!
A quick update about my progress:

  • I just managed to make this work without rolling my own tech at #11794
  • I just made a short video that shows how they look now
  • @pchote: I didn't use Activity.GetTargets but GetDestination which is working just fine, what do you think about it?
  • I had to deal with the Activity Queue which was very painful. What is wrong with that Queue? Why does it is always losing the references? Maybe I'm missing something because I have never coded on C# for this long...
  • Now I want to simplify all this mess I just made so any code review overview would be a huge help at this point

Thanks again guys. This has been a looooong trip but I'm having a lot of fun and that's very important to me

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 15, 2016

Member

The activity queue is actively manipulated by a whole bunch of things (some of which really shouldn't be manipulating it, but many who should), so trying to maintain your own state in parallel to that is going to be very difficult – as i'm sure you already know!

I still strongly suspect the only way to make this work nicely will be to remove all the state from DrawLineToTarget, and push that into Activity.GetTargets so that the current target path can be queried on demand.

Member

pchote commented Aug 15, 2016

The activity queue is actively manipulated by a whole bunch of things (some of which really shouldn't be manipulating it, but many who should), so trying to maintain your own state in parallel to that is going to be very difficult – as i'm sure you already know!

I still strongly suspect the only way to make this work nicely will be to remove all the state from DrawLineToTarget, and push that into Activity.GetTargets so that the current target path can be queried on demand.

@huwpascoe

This comment has been minimized.

Show comment
Hide comment
@huwpascoe

huwpascoe Aug 23, 2016

Contributor

Sorry I couldn't finish this, I know I'm one for rewriting classes (when perhaps I shouldn't) but that activity queue is something else... @Turupawn good luck to ye! 👍

Contributor

huwpascoe commented Aug 23, 2016

Sorry I couldn't finish this, I know I'm one for rewriting classes (when perhaps I shouldn't) but that activity queue is something else... @Turupawn good luck to ye! 👍

@Turupawn

This comment has been minimized.

Show comment
Hide comment
@Turupawn

Turupawn Sep 7, 2016

Member

I could not keep up with the bleed changes on my branch so I switched to this new one which is working just fine: #11998

Member

Turupawn commented Sep 7, 2016

I could not keep up with the bleed changes on my branch so I switched to this new one which is working just fine: #11998

@Mailaender Mailaender removed the Bounty label Nov 10, 2016

@Mailaender Mailaender changed the title from Visualize waypoints set by the player [$50] to Visualize waypoints set by the player Nov 10, 2016

@reaperrr reaperrr added this to the Future milestone Nov 27, 2016

@reaperrr reaperrr modified the milestones: Next release, Future Jun 18, 2017

@pchote pchote removed this from the Next release milestone Mar 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment