Fix Load Game faction filter showing internal names instead of display names

[xan2622]

Fix Load Game faction filter showing internal names instead of display names

Fixes #22472

[ycamlad]

Hey, I was looking at your fix for the faction dropdown issue and I tried to understand it on my own before reaching out.

From what I saw:

The save file stores faction IDs like "ukraine" / "russia"
The UI was passing those directly to Fluent, which didn’t match keys
I found the faction .ftl entries (faction-ukraine, etc.) and tried mapping them

I got pretty close, but I ran into a UI issue where the dropdown ended up showing the same faction multiple times.

If you have any tips for navigating this repo (especially around UI + traits), I’d really appreciate it.

Thanks!

[xan2622]

Hi @ycamlad

Your analysis is correct: the save file uses internal faction IDs, but Fluent expects message keys.

When looking into this, I found that FactionInfo traits from modData.DefaultRules.Actors[SystemActors.World] already link internal names to Fluent keys, so I reused that instead of mapping via .ftl.

For the duplicate issue, my guess is that it depends on when deduplication is applied. In this fix, Distinct() runs on the raw IDs (case-insensitive) before resolving display names, that might be the difference.

For the UI logic, you can look under OpenRA.Mods.Common/Widgets/Logic/, and if I am correct, traits are accessed via actor.TraitInfos<T>(), SystemActors.World is the actor key used to access global rules like factions.

[ycamlad]

Thanks, that helped a lot!

[PunkPun]

Ok.

Unrelated, but I see filters don't get updated on save deletion.

[PunkPun]

https://github.com/OpenRA/OpenRA/wiki/Changelog/_compare/87440584c5d4582d61dd35e9392f686016965ae5...fcbd8af42310f7216205b804256c1f8b88e48d96