-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company value overflows #11005
Comments
We could make it a 64-bit integer. That can be done right away, even if SV6 cannot represent its entire value. Do note that it will always overflow at some point, though. Making it 64-bit merely changes the threshold to a value high enough that most people would be too lazy to even type. |
Is it actually possible to get to this value without cheating? I thought there was a cap preventing the value overflowing on an addition. |
Not if we cap it, I think we have done that with park rating? |
By casting the company value to a 64-bit integer, it can be checked for an overflow and then clamped if that is the case. I implemented this in #11012. |
- Feature: [#10925] Show hovered values on finance charts. - Feature: [#11013] Ctrl+C copies input dialog text to clipboard. - Feature: [#11218] load_park command for console - Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'. - Feature: [#11281] add_news_item command for console - Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity). - Fix: [#475] Water sides drawn incorrectly (original bug). - Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug). - Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin - Fix: [#7094] Back wall edge texture in water missing. - Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly. - Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs. - Fix: [#10928] File browser's date column is too narrow. - Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations. - Fix: [#11005] Company value overflows. - Fix: [#11027] Third color on walls becomes black when saving. - Fix: [#11063] Scrolling position persists when switching tabs in the scenery window. - Fix: [#11106] Crash on getting invalid vehicle index. - Fix: [#11126] Cannot place Frightmare track design. - Fix: [#11208] Cannot export parks with RCT2 DLC objects. - Fix: [#11230] Seat Rotation not imported correctly for hacked rides. - Fix: [#11225] Replay manager cannot handle track designs. - Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number. - Fix: [#11258] Properly remove format codes from imported strings. - Fix: [#11286] Fix banner tooltip colour. - Fix: Small red gardens in RCT1 saves are imported in the wrong colour. - Improved: [#11157] Slimmer virtual floor lines.
OS: Windows 10
Version: 0.2.4
Commit/Build: 2a94632
I think it is not solvable until we have new save file format, but I'd like to issue here to notice to you.
Steps to reproduce:
$214,748,364.70
, which indicatesINT_MAX
Screenshots / Video:
![TELK PARK 2020-03-22 20-16-11](https://user-images.githubusercontent.com/10726524/77327765-00be1780-6d5f-11ea-8f76-ce70b1a0896f.png)
The text was updated successfully, but these errors were encountered: