Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guests enter elevator through the base entrance but appear at the top, then they ride the elevator down. #10372

Closed
tjwrona opened this issue Dec 13, 2019 · 11 comments · Fixed by #11267
Labels
investigate Not sure what the problem is yet.

Comments

@tjwrona
Copy link
Contributor

tjwrona commented Dec 13, 2019

OS: Windows 10
Version: 0.2.4+
Commit/Build: fed417d

I built a park with a simple elevator ride trying to reproduce a different bug and stumbled upon some weird behavior. When guests enter the bottom entrance of the elevator they appear at the top and ride the elevator down.

Steps to reproduce:
Open the attached save file and check out the elevator ride
elevator_bug.zip

Screenshots / Video:
OpenRCT2 2019-12-13 15-11-55_Trim.zip

@tjwrona
Copy link
Contributor Author

tjwrona commented Dec 13, 2019

When I go to move the entrance/exit of the elevator I get this warning in the console output: src\openrct2\actions\RideEntranceExitRemoveAction.hpp:104 (RideEntranceExitRemoveAction::Query)]: Track Element not found. x = 2688, y = 1600, ride = 0, station = 1

@tupaschoal
Copy link
Member

I'm trying to reproduce this, but save starts with guests leaving and they never get in anymore x_x

@tjwrona
Copy link
Contributor Author

tjwrona commented Dec 13, 2019

Yeah the save file seems to not act the same once you reopen it >.<

@tjwrona
Copy link
Contributor Author

tjwrona commented Dec 13, 2019

Good thing I got video proof haha

@tupaschoal
Copy link
Member

tupaschoal commented Dec 13, 2019

Weirdly, I rebuilt it from scratch and couldn't reproduce :(

@tjwrona
Copy link
Contributor Author

tjwrona commented Dec 13, 2019

Me too... very odd.

@tjwrona
Copy link
Contributor Author

tjwrona commented Dec 13, 2019

Here is another map where the bug persists through saving

elevator_bug.zip

@tjwrona
Copy link
Contributor Author

tjwrona commented Dec 14, 2019

Some additional info: I moved the entrance/exit at the base so they weren't directly under the entrance/exit at the top and it temporarily fixed the issue.... but then after about another hour of gameplay the bug came back even though the entrances/exits are not directly above each other.

@Gymnasiast Gymnasiast added the investigate Not sure what the problem is yet. label Dec 14, 2019
@tupaschoal
Copy link
Member

I went as far as 0d2fd33 and it still happened, so it is either an old regression or has always been a bug.

@tellovishous
Copy link
Contributor

I'm also having this same issue the African Diamond Mines scenario.

@SpartanFrederic104
Copy link
Contributor

SpartanFrederic104 commented Apr 10, 2020

Still having this issue in v0.2.5. Definitely looks like regression as I don't recall this issue having been present in 0.2.2 or even RCT2 vanilla. At the time of writing this and #11261, my commit/build is fdf9806.
Test Park 2020-04-10 09-14-32
It always happens upon loading a saved game or starting a new scenario with an elevator as a prebuilt ride. Doesn't matter if there's two stations or four.

duncanspumpkin added a commit to duncanspumpkin/OpenRCT2 that referenced this issue Apr 11, 2020
…s did not export correctly

Mistake made whilst refactoring that assumed that station indexes are set on only station pieces.
AaronVanGeffen added a commit that referenced this issue Apr 11, 2020
Fix #10372, #10509, #10806. Lift base sections did not export correctly
Gymnasiast added a commit that referenced this issue Apr 17, 2020
- Feature: [#10925] Show hovered values on finance charts.
- Feature: [#11013] Ctrl+C copies input dialog text to clipboard.
- Feature: [#11218] load_park command for console
- Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'.
- Feature: [#11281] add_news_item command for console
- Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity).
- Fix: [#475] Water sides drawn incorrectly (original bug).
- Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug).
- Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin
- Fix: [#7094] Back wall edge texture in water missing.
- Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly.
- Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs.
- Fix: [#10928] File browser's date column is too narrow.
- Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations.
- Fix: [#11005] Company value overflows.
- Fix: [#11027] Third color on walls becomes black when saving.
- Fix: [#11063] Scrolling position persists when switching tabs in the scenery window.
- Fix: [#11106] Crash on getting invalid vehicle index.
- Fix: [#11126] Cannot place Frightmare track design.
- Fix: [#11208] Cannot export parks with RCT2 DLC objects.
- Fix: [#11230] Seat Rotation not imported correctly for hacked rides.
- Fix: [#11225] Replay manager cannot handle track designs.
- Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number.
- Fix: [#11258] Properly remove format codes from imported strings.
- Fix: [#11286] Fix banner tooltip colour.
- Fix: Small red gardens in RCT1 saves are imported in the wrong colour.
- Improved: [#11157] Slimmer virtual floor lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Not sure what the problem is yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants