Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third color on objects becoming black when saving #11027

Closed
SupraGL opened this issue Mar 25, 2020 · 4 comments
Closed

Third color on objects becoming black when saving #11027

SupraGL opened this issue Mar 25, 2020 · 4 comments
Assignees
Labels
bug Something went wrong.

Comments

@SupraGL
Copy link

SupraGL commented Mar 25, 2020

OS: Windows 7
Version: 0.2.5
Commit/Build: 4f6e77e and 302fe1c
Applies both on release and develop.

When we place a scenery object with a third color different from black, then save the game, then open the save, it becomes black.

  • Reproducible in RCT2 (vanilla)? No
  • Specific to multiplayer? No

Steps to reproduce:

  1. Place a scenery object with a third color.
  2. Save the game.
  3. Open the save.

Screenshots / Video:
Before:
image
After:
image

Save game:
test color.zip

@deurklink
Copy link
Contributor

To devs: do you think there maybe could be a new release version after fixing this? I can see this affect a ton of savegames in the future..

@ocalhoun6
Copy link
Contributor

I just tried loading the save game provided on an older version of OpenRCT2, and the third colors are indeed black. It's being saved that way, not just a display issue or a loading issue. So, yeah -- it's going to affect a lot of saved games.

@AaronVanGeffen
Copy link
Member

This shows a real disadvantage of fewer people using the develop builds nowadays. I’m sorry this went unnoticed on our end.

We should make a replay test for this to ensure it doesn’t happen again.

@AaronVanGeffen AaronVanGeffen added the bug Something went wrong. label Mar 25, 2020
@Ziscor
Copy link

Ziscor commented Mar 25, 2020

Addition: when changing colours on an already placed/re-coloured object from an old save file, and then saving, the save file ignores the change and the colour is reverted to what it was before.

It only goes black when placing new instances of the object.

@Gymnasiast Gymnasiast self-assigned this Mar 25, 2020
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Mar 25, 2020
Gymnasiast added a commit that referenced this issue Apr 17, 2020
- Feature: [#10925] Show hovered values on finance charts.
- Feature: [#11013] Ctrl+C copies input dialog text to clipboard.
- Feature: [#11218] load_park command for console
- Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'.
- Feature: [#11281] add_news_item command for console
- Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity).
- Fix: [#475] Water sides drawn incorrectly (original bug).
- Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug).
- Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin
- Fix: [#7094] Back wall edge texture in water missing.
- Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly.
- Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs.
- Fix: [#10928] File browser's date column is too narrow.
- Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations.
- Fix: [#11005] Company value overflows.
- Fix: [#11027] Third color on walls becomes black when saving.
- Fix: [#11063] Scrolling position persists when switching tabs in the scenery window.
- Fix: [#11106] Crash on getting invalid vehicle index.
- Fix: [#11126] Cannot place Frightmare track design.
- Fix: [#11208] Cannot export parks with RCT2 DLC objects.
- Fix: [#11230] Seat Rotation not imported correctly for hacked rides.
- Fix: [#11225] Replay manager cannot handle track designs.
- Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number.
- Fix: [#11258] Properly remove format codes from imported strings.
- Fix: [#11286] Fix banner tooltip colour.
- Fix: Small red gardens in RCT1 saves are imported in the wrong colour.
- Improved: [#11157] Slimmer virtual floor lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

No branches or pull requests

6 participants