Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay system cannot build tracked rides #11225

Closed
janisozaur opened this issue Apr 4, 2020 · 5 comments · Fixed by #11226
Closed

Replay system cannot build tracked rides #11225

janisozaur opened this issue Apr 4, 2020 · 5 comments · Fixed by #11226
Labels
bug Something went wrong.
Milestone
v0.2.6 - bugfix r...

Comments

@janisozaur
Copy link
Member

Version: current develop
Commit/Build: 13a2f67

The attached replay, submitted as an artifact of #11190, should build attached park, but none of the tracked rides are created. Instead, logs contain following:

WARNING[../src/openrct2/actions/RideSetStatus.hpp:66 (Query)]: Invalid game command for ride 1
WARNING[../src/openrct2-ui/../openrct2/actions/RideSetPriceAction.hpp:63 (Query)]: Invalid game command, ride_id = 1
WARNING[../src/openrct2-ui/../openrct2/actions/RideSetPriceAction.hpp:63 (Query)]: Invalid game command, ride_id = 1
WARNING[../src/openrct2-ui/../openrct2/actions/RideSetPriceAction.hpp:63 (Query)]: Invalid game command, ride_id = 1
WARNING[../src/openrct2-ui/../openrct2/actions/RideSetPriceAction.hpp:63 (Query)]: Invalid game command, ride_id = 1
WARNING[../src/openrct2-ui/../openrct2/actions/RideSetPriceAction.hpp:63 (Query)]: Invalid game command, ride_id = 1

park_11225.sv6.txt
replay_11225.sv6r.txt
@janisozaur
Copy link
Member Author

ping @ZehMatt @duncanspumpkin

@janisozaur
Copy link
Member Author

I'd expect this to be a regression, perhaps from when prebuilts support was added to multiplayer?

Also, don't know how sprite checksum mismatch is reported, but I'm pretty sure missing half the park should trigger it, but there was nothing reported.

@janisozaur
Copy link
Member Author

It's especially odd, as I did test it locally a few days ago and seemed to work fine. I only tested it on my local Linux machine with a very simple recording, though it did include building a tracked ride and it replayed correctly.

@duncanspumpkin
Copy link
Contributor

Issue caused by flags not being passed down to the internal game actions of track design placement.

@duncanspumpkin
Copy link
Contributor

It wont cause any issues apart from prevent replays recording correctly.

duncanspumpkin added a commit to duncanspumpkin/OpenRCT2 that referenced this issue Apr 5, 2020
@duncanspumpkin
Fix OpenRCT2#11225: Track design replays.
dbe7937 
The replay state was not being passed to all sub actions this prevented the replay from working. Note replays made before this still work its just they couldn't be replayed.

name the flag

Update changelog
@duncanspumpkin duncanspumpkin linked a pull request Apr 5, 2020 that will close this issue
Fix track design replays. #11226
Merged
duncanspumpkin added a commit to duncanspumpkin/OpenRCT2 that referenced this issue Apr 5, 2020
@duncanspumpkin
Fix OpenRCT2#11225: Track design replays.
de7051d 
The replay state was not being passed to all sub actions this prevented the replay from working. Note replays made before this still work its just they couldn't be replayed.

name the flag

Update changelog
@tupaschoal tupaschoal added the bug Something went wrong. label Apr 5, 2020
Gymnasiast added a commit that referenced this issue Apr 17, 2020
@Gymnasiast
Release v0.2.6
6c3c857 
- Feature: [#10925] Show hovered values on finance charts.
- Feature: [#11013] Ctrl+C copies input dialog text to clipboard.
- Feature: [#11218] load_park command for console
- Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'.
- Feature: [#11281] add_news_item command for console
- Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity).
- Fix: [#475] Water sides drawn incorrectly (original bug).
- Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug).
- Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin
- Fix: [#7094] Back wall edge texture in water missing.
- Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly.
- Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs.
- Fix: [#10928] File browser's date column is too narrow.
- Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations.
- Fix: [#11005] Company value overflows.
- Fix: [#11027] Third color on walls becomes black when saving.
- Fix: [#11063] Scrolling position persists when switching tabs in the scenery window.
- Fix: [#11106] Crash on getting invalid vehicle index.
- Fix: [#11126] Cannot place Frightmare track design.
- Fix: [#11208] Cannot export parks with RCT2 DLC objects.
- Fix: [#11230] Seat Rotation not imported correctly for hacked rides.
- Fix: [#11225] Replay manager cannot handle track designs.
- Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number.
- Fix: [#11258] Properly remove format codes from imported strings.
- Fix: [#11286] Fix banner tooltip colour.
- Fix: Small red gardens in RCT1 saves are imported in the wrong colour.
- Improved: [#11157] Slimmer virtual floor lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong.
Projects
None yet
Milestone
v0.2.6 - bugfix release for 0.2.5
Development

Successfully merging a pull request may close this issue.

Fix track design replays. duncanspumpkin/OpenRCT2
3 participants
@janisozaur @duncanspumpkin @tupaschoal