Load_Park feature for headless server #11218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New feature "load_park name" from "save" folder.
janisozaur
reviewed
Apr 3, 2020
| @@ -1687,6 +1701,7 @@ static constexpr const console_command console_command_table[] = { | |||
| "Loading a scenery group will not load its associated objects.\n" | |||
| "This is a safer method opposed to \"open object_selection\".", | |||
| "load_object <objectfilenodat>" }, | |||
| { "load_park", cc_load_park, "Load park", "load_park [name]" }, | |||
There was a problem hiding this comment.
Please mention it will read a file from user's save directory.
There was a problem hiding this comment.
Why is the name marked as optional? Makes no sense to me without the park name and it will fail anyway.
There was a problem hiding this comment.
This was a copy from save_park. I did not change that brackets. Sorry. should be just "nameofsave".
janisozaur
reviewed
Apr 3, 2020
| char savePath[MAX_PATH]; | ||
| platform_get_user_directory(savePath, "save", sizeof(savePath)); | ||
| safe_strcat_path(savePath, argv[0].c_str(), sizeof(savePath)); | ||
| path_append_extension(savePath, ".sv6", sizeof(savePath)); |
There was a problem hiding this comment.
It should allow user to include .sv6 in the name. Personally I would even expect a filename here, without altering it. I guess it should also allow for .sc6. I recently was told there's String::EndsWith function that can be used for that.
There was a problem hiding this comment.
Gonna add that soon and will do another commit/PR.
There was a problem hiding this comment.
This PR won't be merged until after the v0.2.6 release, so please amend this PR instead.
load_park is now <name> instead of [name]
allow to specify park via absolute path make .sv6 filename extension optional support .sc6 filename extension, but default to .sv6
janisozaur
added a commit
that referenced
this pull request
Apr 16, 2020
AaronVanGeffen
pushed a commit
that referenced
this pull request
Apr 16, 2020
Gymnasiast
added a commit
that referenced
this pull request
Apr 17, 2020
- Feature: [#10925] Show hovered values on finance charts. - Feature: [#11013] Ctrl+C copies input dialog text to clipboard. - Feature: [#11218] load_park command for console - Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'. - Feature: [#11281] add_news_item command for console - Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity). - Fix: [#475] Water sides drawn incorrectly (original bug). - Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug). - Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin - Fix: [#7094] Back wall edge texture in water missing. - Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly. - Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs. - Fix: [#10928] File browser's date column is too narrow. - Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations. - Fix: [#11005] Company value overflows. - Fix: [#11027] Third color on walls becomes black when saving. - Fix: [#11063] Scrolling position persists when switching tabs in the scenery window. - Fix: [#11106] Crash on getting invalid vehicle index. - Fix: [#11126] Cannot place Frightmare track design. - Fix: [#11208] Cannot export parks with RCT2 DLC objects. - Fix: [#11230] Seat Rotation not imported correctly for hacked rides. - Fix: [#11225] Replay manager cannot handle track designs. - Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number. - Fix: [#11258] Properly remove format codes from imported strings. - Fix: [#11286] Fix banner tooltip colour. - Fix: Small red gardens in RCT1 saves are imported in the wrong colour. - Improved: [#11157] Slimmer virtual floor lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature "load_park name" from "save" folder. Allows to load a new map while playing with headless server. Clients won't disconnect anymore as no server restart is needed.
The save files need to be in the "save" directory to get detected by the server.