Scenery window scrolling issue

[Umdlye]

OS: Windows 10 (x64)
Version: 0.2.5
Commit/Build: da2ba0b

When you scroll down a long scenery tab, then switch to a different tab, the scroll position often persists. This can lead to a scenery tab appearing empty if the scroll position is below the last item in the tab.

This doesn't seem to happen all the time, but often enough to be an annoyance.

• Reproducible in RCT2 (vanilla)?
• Specific to multiplayer?

Steps to reproduce:

1. Open scenery window
2. Open a scenery tab with a lot of items and scroll down
3. Switch to a different scenery tab, observe that it will scroll down to where you were in the previous tab

[IntelOrca]

I think this has been an issue for a long time, possibly vanilla bug - not sure.

[Umdlye]

I can reproduce it in the 0.2.4 release but not in vanilla.

[jeysbach]

I managed to fix this by adding the following to the code that's run when a tab is clicked:

// Reset scroll position if moving to another tab
if (gWindowSceneryActiveTabIndex != widgetIndex - WIDX_SCENERY_TAB_1)
{
    w->scrolls->v_top = 0;
}

However, this feels kinda hacky and I don't feel like I'm using the scrolls struct correctly by doing this.

This also means the view always goes to the top of the tab, instead of to the selected scenery if something is selected.

[jeysbach]

I found another fix that works better and created a new PR for that.

[tupaschoal]

Ok, Just for reference, you can update the same PR in the future, there is no need to create a new one :)