Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot save parks with RCT2 DLC objects #11208

Closed
VersionEins opened this issue Apr 2, 2020 · 8 comments · Fixed by #11212
Closed

Cannot save parks with RCT2 DLC objects #11208

VersionEins opened this issue Apr 2, 2020 · 8 comments · Fixed by #11212
Assignees
@Gymnasiast
Labels
bug Something went wrong. regression An issue that was made since the last release.
Milestone
v0.2.6 - bugfix r...

Comments

@VersionEins
Copy link

OS: Windows 10
Version: 0.2.5-81
Commit/Build: 08d38f3

I can't save the attached savegame when activating the option to export plug-in objects.

Steps to reproduce:

  1. Load the save
  2. Check "Export Plug-In Objects" in the options menu
  3. Try to save the game

Save game:
V1 380.zip
@Gymnasiast Gymnasiast added the investigate Not sure what the problem is yet. label Apr 2, 2020
@Gymnasiast
Copy link
Member

Perhaps you have objects in your object folder that are broken. Can you provide a ZIP for us? (Since the file will probably be too big for Github, you might need to split it up into chunks of 10 MB, or provide a Dropbox or MEGA link or something like that.)

@VersionEins
Copy link
Author

Here's the link:
https://drive.google.com/open?id=1tvkrobZaiwRrjgjzSlMDDwXa0fPG_ScM

It works fine with 2.4, btw.

@Umdlye
Copy link
Contributor

Umdlye commented Apr 2, 2020 •
edited
Loading

It tries to export PANDAGR.dat, but in object selection it shows the .parkobj version.

VERBOSE: exporting object PANDAGR
ERROR[D:\a\OpenRCT2\OpenRCT2\src\openrct2\rct2\S6Exporter.cpp:1722 (scenario_save)]: Unable to save park: 'Header found in object file does not match object to pack.'
VERBOSE: show error, Save Game�Game save failed!

This object conflict appears when starting the game:

Object conflict: 'C:\Users\Steph\Documents\OpenRCT2\bin\data\object\official\scenery_small\rct2.dlc.pandagr.parkobj'
               : 'C:\Users\Steph\Documents\OpenRCT2\object\PANDAGR.DAT'

The .dat object is in this zip: PANDAGR.zip

May be caused by OpenRCT2/objects#61?

@Gymnasiast
Copy link
Member

Hm, that makes sense. Thanks for finding that out, that helps a great deal.

@janisozaur
Copy link
Member

Should this be included in v0.2.6 milestone?

@Gymnasiast
Copy link
Member

@janisozaur I have added it. It's not entirely a showstopper, but I think I might be able to fix it tomorrow.

@Gymnasiast Gymnasiast self-assigned this Apr 2, 2020
@Gymnasiast Gymnasiast added bug Something went wrong. regression An issue that was made since the last release. and removed investigate Not sure what the problem is yet. labels Apr 2, 2020
@Gymnasiast Gymnasiast linked a pull request Apr 2, 2020 that will close this issue
Fix #11208: Cannot export parks with RCT2 DLC objects #11212
Merged
@Gymnasiast Gymnasiast changed the title Savegame not possible when exporting plug-in objects Cannot export parks with RCT2 DLC objects Apr 2, 2020
@Gymnasiast Gymnasiast changed the title Cannot export parks with RCT2 DLC objects Cannot save parks with RCT2 DLC objects Apr 2, 2020
@Umdlye
Copy link
Contributor

Umdlye commented Apr 2, 2020

Well, it does create a save despite the error, and the save is unusable (kicks you to the title screen). So I guess if you overwrite an old save with it, it's kind of a showstopper 😛

@Gymnasiast
Copy link
Member

Good point. Well, it will go into 0.2.6 anyway.

duncanspumpkin pushed a commit that referenced this issue Apr 4, 2020
@Gymnasiast
Fix #11208: Cannot export parks with RCT2 DLC objects (#11212)
13a2f67 
* Do not try to export official objects

* Do not override legacy object's source games

* Amend changelog
Gymnasiast added a commit that referenced this issue Apr 17, 2020
@Gymnasiast
Release v0.2.6
6c3c857 
- Feature: [#10925] Show hovered values on finance charts.
- Feature: [#11013] Ctrl+C copies input dialog text to clipboard.
- Feature: [#11218] load_park command for console
- Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'.
- Feature: [#11281] add_news_item command for console
- Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity).
- Fix: [#475] Water sides drawn incorrectly (original bug).
- Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug).
- Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin
- Fix: [#7094] Back wall edge texture in water missing.
- Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly.
- Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs.
- Fix: [#10928] File browser's date column is too narrow.
- Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations.
- Fix: [#11005] Company value overflows.
- Fix: [#11027] Third color on walls becomes black when saving.
- Fix: [#11063] Scrolling position persists when switching tabs in the scenery window.
- Fix: [#11106] Crash on getting invalid vehicle index.
- Fix: [#11126] Cannot place Frightmare track design.
- Fix: [#11208] Cannot export parks with RCT2 DLC objects.
- Fix: [#11230] Seat Rotation not imported correctly for hacked rides.
- Fix: [#11225] Replay manager cannot handle track designs.
- Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number.
- Fix: [#11258] Properly remove format codes from imported strings.
- Fix: [#11286] Fix banner tooltip colour.
- Fix: Small red gardens in RCT1 saves are imported in the wrong colour.
- Improved: [#11157] Slimmer virtual floor lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gymnasiast Gymnasiast

Labels
bug Something went wrong. regression An issue that was made since the last release.
Projects
None yet
Milestone
v0.2.6 - bugfix release for 0.2.5
Development

Successfully merging a pull request may close this issue.

Fix #11208: Cannot export parks with RCT2 DLC objects Gymnasiast/OpenRCT2
4 participants
@janisozaur @Gymnasiast @Umdlye @VersionEins