Simple implementation of copy input to clipboard (Ctrl+C) #11013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daandeheij
changed the title
daandeheij
changed the title
|
Can you add a screenshot of what the message looks like to the PR description, please? In any case, I'm wondering whether we need an information pop-up or not. |
|
I just added a screenshot. I think ideal would be to have some sort of pop-up/message box notify the user that the text was copied, and then to disappear on its own. This current message sticks around until the next key/mouse press, which is slightly inconvenient. |
janisozaur
reviewed
Mar 24, 2020
|
Could you add a changelog entry as well? (We just released v0.2.5 tonight, so it'll have to go under v0.2.5+.) |
This is a simple implementation of copying all current input text to the clipboard using ctrl+c. A simple dialog acknowledges that text is copied. This commit includes a new string ID for the text in this dialog.
Co-Authored-By: Michał Janiszewski <janisozaur@users.noreply.github.com>
daandeheij
force-pushed
the
copy_input_string
branch
from
dd87385
to
e9121e3
Compare
|
Added a changelog entry just now under v.0.2.5+ |
19 tasks
|
@daandeheij in future have as your commit message |
Gymnasiast
added a commit
that referenced
this pull request
Apr 17, 2020
- Feature: [#10925] Show hovered values on finance charts. - Feature: [#11013] Ctrl+C copies input dialog text to clipboard. - Feature: [#11218] load_park command for console - Feature: [#11272] Option for toggling notifications for 'Ride casualties' and 'Stuck or stalled vehicles'. - Feature: [#11281] add_news_item command for console - Feature: [#11300] Add powered launch and reverse incline launched shuttle mode to the Stand-Up Roller Coaster (for RCT1 parity). - Fix: [#475] Water sides drawn incorrectly (original bug). - Fix: [#6123, #7907, #9472, #11028] Cannot build some track designs with 4 stations (original bug). - Fix: [#6238] Invalid tile elem iteration in Guest::UpdateUsingBin - Fix: [#7094] Back wall edge texture in water missing. - Fix: [#9719] Hacked walls in RCT1 saves are imported incorrectly. - Fix: [#10372, #10509, #10806] Lift base sections incorrectly exporting, causing various lift related bugs. - Fix: [#10928] File browser's date column is too narrow. - Fix: [#10951, #11160] Attempting to place park entrances creates ghost entrances in random locations. - Fix: [#11005] Company value overflows. - Fix: [#11027] Third color on walls becomes black when saving. - Fix: [#11063] Scrolling position persists when switching tabs in the scenery window. - Fix: [#11106] Crash on getting invalid vehicle index. - Fix: [#11126] Cannot place Frightmare track design. - Fix: [#11208] Cannot export parks with RCT2 DLC objects. - Fix: [#11230] Seat Rotation not imported correctly for hacked rides. - Fix: [#11225] Replay manager cannot handle track designs. - Fix: [#11246] Fix Various Import/Export issues with Boat locations, balloon frame number. - Fix: [#11258] Properly remove format codes from imported strings. - Fix: [#11286] Fix banner tooltip colour. - Fix: Small red gardens in RCT1 saves are imported in the wrong colour. - Improved: [#11157] Slimmer virtual floor lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to copy input strings to the clipboard was requested in #10955. This is a very simple implementation using Ctrl+C, as suggested by @janisozaur.
I wanted to include a simple acknowledgement that the text is copied (as this is not very clear as selecting text is not possible). I have used the
context_show_errorin this PR, but I am not sure whether this is the most appropriate way. Of course, this message can also be omitted.The following screenshot shows the
context_show_error. Note that the string in this commit iscopied text to clipboard, contrary to this screenshot (I changed the string after taking the screenshot).