Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title sequence script caches (not necessarily crashes, but I got it to anyway) #5768

Closed
spacek531 opened this issue Jul 3, 2017 · 3 comments
Labels
bug Something went wrong. crash Game exits suddenly.

Comments

@spacek531
Copy link
Contributor

spacek531 commented Jul 3, 2017

OS: windows 8.1
Version: 0.0.8
Commit/Build: aec214c

Two issues:

  1. The program appears to cache the script file instead of loading it fresh every time it loads the main menu. Is this intentional? It is a bit annoying for developing title sequences. Expected behavior: going to the main menu screen loads the latest version of the sequence's script file.

  2. I managed to get the game to crash by swapping the names of two sequences in my title sequence folder. The game couldn't find any of the parks in the specified folder because the script cached instead of reloading the script. Starting the game anew loaded the script correctly. (I renamed the 0.0.4 sequence folder to the working folder for the 0.1.0 sequence)

Here's a dump of that crash:

pls dont cache title sequence scripts.zip

@spacek531 spacek531 changed the title Title sequence script caches (not necessarily crashes) Title sequence script caches (not necessarily crashes, but I got it to anyway) Jul 3, 2017
@rwjuk rwjuk added crash Game exits suddenly. bug Something went wrong. labels Jul 3, 2017
@Nubbie
Copy link
Contributor

Nubbie commented Jul 7, 2017

Related #5798?
Problem with kernelbase.dll, but hopefully still valuable

Error message;
Unhandled exception at 0x00007FFDAC9495FC in ba6b205c-10ee-4054-9578-7ca9a4febba6(aec214c_x86-64).dmp: Microsoft C++ exception: IOException at memory location 0x000000C3A621F298.

Call stack;

 	KERNELBASE.dll!RaiseException�()	Unknown
 	[External Code]	
>	openrct2.dll!FileStream::FileStream(const char * path=0x000000c3a621f300, int fileMode) Line 89	C++
 	openrct2.dll!TitleSequenceGetParkHandle(TitleSequence * seq, unsigned __int64 index) Line 158	C++
 	openrct2.dll!TitleSequencePlayer::ExecuteCommand(const TitleCommand * command) Line 292	C++
 	openrct2.dll!TitleSequencePlayer::Update() Line 143	C++
 	openrct2.dll!title_load() Line 152	C++
 	openrct2.dll!game_load_or_quit(int * eax=0x0000000000000070, int * ebx=0x000000c3a621f5f8, int * ecx=0xffffffffffffffff, int * edx, int * esi=0x000000c3a621f610, int * edi=0x000000c3a621f648, int * ebp=0x000000c3a621f638) Line 911	C
 	openrct2.dll!game_do_command_p(int command, int * eax=0x000000c3a621f5f0, int * ebx=0x000000c3a621f5f8, int * ecx=0x000000c3a621f600, int * edx=0x000000c3a621f608, int * esi=0x000000c3a621f610, int * edi=0x000000c3a621f648, int * ebp=0x000000c3a621f638) Line 577	C
 	openrct2.dll!window_top_toolbar_dropdown(rct_window * w=0x00007ffd79660880, short widgetIndex, int dropdownIndex) Line 641	C
 	openrct2.dll!input_state_widget_pressed(int x=117, int y=135, int state=2, short widgetIndex, rct_window * w=0x00007ffd79660880, rct_widget * widget=0x00007ffd78fcbc70) Line 1248	C
 	openrct2.dll!game_handle_input_mouse(int x=117, int y=135, int state=2) Line 323	C
 	openrct2.dll!game_handle_input(...) Line 130	C
 	openrct2.dll!game_update(...) Line 351	C
 	openrct2.dll!rct2_update(...) Line 411	C
 	openrct2.dll!OpenRCT2::Context::RunVariableFrame() Line 423	C++
 	openrct2.dll!OpenRCT2::Context::RunGameLoop() Line 361	C++
 	openrct2.dll!OpenRCT2::Context::RunOpenRCT2(int argc=-1506370176, char * * argv=0x0000000003040800) Line 136	C++
 	openrct2.dll!NormalisedMain(int argc=1, char * * argv=0x000000c3a630b860) Line 65	C++
 	openrct2.dll!LaunchOpenRCT2(int argc, wchar_t * * argvW) Line 55	C++
 	[External Code]	

Locals;

+		this	0x000000c3a6394450 {_file=??? _ownsFilePtr=??? _canRead=??? ...}	FileStream *
		fileMode	Variable is optimized away and not available.	
		mode	Variable is optimized away and not available.	
+		modeW	0x000000c3afc161c0 <Error reading characters of string.>	wchar_t *
+		path	0x000000c3a621f300 "C:\\Users\\pat\\Documents\\OpenRCT2\\title sequences\\Spacek 008 Sequence\\Ill Paradise timer base.sv6"	const char *
+		pathW	0x000000c3af448670 <Error reading characters of string.>	wchar_t *

Autos;

-		path	0x000000c3a621f300 "C:\\Users\\pat\\Documents\\OpenRCT2\\title sequences\\Spacek 008 Sequence\\Ill Paradise timer base.sv6"	const char *
			67 'C'	const char
-		this	0x000000c3a6394450 {_file=??? _ownsFilePtr=??? _canRead=??? ...}	FileStream *
+		IStream	{...}	IStream
		_file	<Unable to read memory>	
		_ownsFilePtr	<Unable to read memory>	
		_canRead	<Unable to read memory>	
		_canWrite	<Unable to read memory>	
		_disposed	<Unable to read memory>	
		_fileSize	<Unable to read memory>	

@Chaosmeister
Copy link
Contributor

I'm looking at this

@Chaosmeister
Copy link
Contributor

Chaosmeister commented Jul 9, 2017

The crash is fixed.

What about the other request?
As a workaround you can reload the script it in the misc-settings menu by selecting another sequence and then selecting your sequence again.

janisozaur added a commit to janisozaur/OpenRCT2 that referenced this issue Aug 9, 2017
- Feature: [OpenRCT2#5815] Add cheat to ignore research status and access rides/scenery not yet invented.
- Feature: [OpenRCT2#5857] Keyboard shortcut for clear scenery.
- Feature: [OpenRCT2#5877] Allow up to 16 stations to be synchronised
- Feature: [OpenRCT2#5970] The Bobsleigh Roller Coaster now supports on-ride photos.
- Feature: [OpenRCT2#5991] Allow all tracked rides that can be tested without guests to the Track Designer
- Fix: [OpenRCT2#2127, OpenRCT2#2229, OpenRCT2#5586] Mountain tool cost calculation
- Fix: [OpenRCT2#3589] Crash due to invalid footpathEntry in path_paint
- Fix: [OpenRCT2#3852] Constructing path not clearing scenery on server.
- Fix: [OpenRCT2#4455] Crash in window_sign_invalidate due to original bug
- Fix: [OpenRCT2#4715] Fix OpenGL rendering of water when zoomed. See OpenRCT2#5890.
- Fix: [OpenRCT2#4931] Crash in path_paint - footpathentry was null
- Fix: [OpenRCT2#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity
- Fix: [OpenRCT2#5768] Prevent loading non-existent title sequences.
- Fix: [OpenRCT2#5858] Crash when using custom ride with no colour presets.
- Fix: [OpenRCT2#5865] Ride preview flickering on uneven terrain or mid air.
- Fix: [OpenRCT2#5872] Incorrect OpenGL rendering of masked sprites
- Fix: [OpenRCT2#5880] Leaving bumper cars without building causes assertion.
- Fix: [OpenRCT2#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours.
- Fix: [OpenRCT2#5912] Negative queue when moving entrance in paused state.
- Fix: [OpenRCT2#5920] Placing guest spawn doesn't do anything every 3rd click
- Fix: [OpenRCT2#5939] Crash when importing 'Six Flags Santa Fe'.
- Fix: [OpenRCT2#5977] Custom music files not showing up in music list
- Fix: [OpenRCT2#5981] Ride list doesn't update after using quick demolish.
- Fix: [OpenRCT2#5984] Allow socket binding to same port after crash
- Fix: [OpenRCT2#5998] Staff not getting paid / no loan interest.
- Fix: [OpenRCT2#6026] 'Select ride to advertise' dropdown does not display all items.
- Fix: [OpenRCT2#6052] Unable to place entrance/exit on certain ride types.
- Fix: [OpenRCT2#6071] Quick demolish can delete protected ride.
- Fix: [OpenRCT2#6111] Mute button always visible in editor.
- Fix: [OpenRCT2#6113] Track preview shows incorrect highest drop height.
- Improved: [OpenRCT2#2223] Change mountain tool to ignore higher surrounding tiles.
- Improved: [OpenRCT2#4301] Leading and trailing whitespace in player name is now removed.
- Improved: [OpenRCT2#5859] OpenGL rendering performance
- Improved: [OpenRCT2#5863] Switching drawing engines no longer requires the application to restart.
- Improved: [OpenRCT2#6003] Doors placed on tracks will now work with all vehicles
- Improved: [OpenRCT2#6037] Autosaves are now stored in a subfolder
- Improved: The land tool buttons can now be held down to increase/decrease size.
- Improved: Dropdowns longer than 32 items overflow into columns.
- Improved: Ride Type option in ride window is now a dropdown.
- Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
janisozaur added a commit that referenced this issue Aug 9, 2017
- Feature: [#5815] Add cheat to ignore research status and access rides/scenery not yet invented.
- Feature: [#5857] Keyboard shortcut for clear scenery.
- Feature: [#5877] Allow up to 16 stations to be synchronised
- Feature: [#5970] The Bobsleigh Roller Coaster now supports on-ride photos.
- Feature: [#5991] Allow all tracked rides that can be tested without guests to the Track Designer
- Fix: [#2127, #2229, #5586] Mountain tool cost calculation
- Fix: [#3589] Crash due to invalid footpathEntry in path_paint
- Fix: [#3852] Constructing path not clearing scenery on server.
- Fix: [#4455] Crash in window_sign_invalidate due to original bug
- Fix: [#4715] Fix OpenGL rendering of water when zoomed. See #5890.
- Fix: [#4931] Crash in path_paint - footpathentry was null
- Fix: [#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity
- Fix: [#5768] Prevent loading non-existent title sequences.
- Fix: [#5858] Crash when using custom ride with no colour presets.
- Fix: [#5865] Ride preview flickering on uneven terrain or mid air.
- Fix: [#5872] Incorrect OpenGL rendering of masked sprites
- Fix: [#5880] Leaving bumper cars without building causes assertion.
- Fix: [#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours.
- Fix: [#5912] Negative queue when moving entrance in paused state.
- Fix: [#5920] Placing guest spawn doesn't do anything every 3rd click
- Fix: [#5939] Crash when importing 'Six Flags Santa Fe'.
- Fix: [#5977] Custom music files not showing up in music list
- Fix: [#5981] Ride list doesn't update after using quick demolish.
- Fix: [#5984] Allow socket binding to same port after crash
- Fix: [#5998] Staff not getting paid / no loan interest.
- Fix: [#6026] 'Select ride to advertise' dropdown does not display all items.
- Fix: [#6052] Unable to place entrance/exit on certain ride types.
- Fix: [#6071] Quick demolish can delete protected ride.
- Fix: [#6111] Mute button always visible in editor.
- Fix: [#6113] Track preview shows incorrect highest drop height.
- Improved: [#2223] Change mountain tool to ignore higher surrounding tiles.
- Improved: [#4301] Leading and trailing whitespace in player name is now removed.
- Improved: [#5859] OpenGL rendering performance
- Improved: [#5863] Switching drawing engines no longer requires the application to restart.
- Improved: [#6003] Doors placed on tracks will now work with all vehicles
- Improved: [#6037] Autosaves are now stored in a subfolder
- Improved: The land tool buttons can now be held down to increase/decrease size.
- Improved: Dropdowns longer than 32 items overflow into columns.
- Improved: Ride Type option in ride window is now a dropdown.
- Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong. crash Game exits suddenly.
Projects
None yet
Development

No branches or pull requests

4 participants