Rendering of textured surface is broken with OpenGL #5890
Comments
janisozaur
added
bug
|
If you look at the X8DrawingEngine you can see that FillRect has a bunch of features which are not implemented in the shader. |
|
OpenGL does not handle primary and secondary colours for special sprites that have alternative zoomed images. Easy to fix. |
duncanspumpkin
added a commit
to duncanspumpkin/OpenRCT2
that referenced
this issue
Aug 2, 2017
…pengl. Mistake made due to a missunderstanding of how the software renderer works. At this point in the software renderer the primary and secondary colours are already calculated into the palette so can be ignored. In opengl the colours still need to be passed to the command queue. Fixes OpenRCT2#4715 as well.
duncanspumpkin
added a commit
to duncanspumpkin/OpenRCT2
that referenced
this issue
Aug 2, 2017
…pengl. Mistake made due to a missunderstanding of how the software renderer works. At this point in the software renderer the primary and secondary colours are already calculated into the palette so can be ignored. In opengl the colours still need to be passed to the command queue. Fixes OpenRCT2#4715 as well. Update changelog
duncanspumpkin
added a commit
that referenced
this issue
Aug 2, 2017
…6109) Mistake made due to a missunderstanding of how the software renderer works. At this point in the software renderer the primary and secondary colours are already calculated into the palette so can be ignored. In opengl the colours still need to be passed to the command queue. Fixes #4715 as well. Update changelog
janisozaur
added a commit
to janisozaur/OpenRCT2
that referenced
this issue
Aug 9, 2017
- Feature: [OpenRCT2#5815] Add cheat to ignore research status and access rides/scenery not yet invented. - Feature: [OpenRCT2#5857] Keyboard shortcut for clear scenery. - Feature: [OpenRCT2#5877] Allow up to 16 stations to be synchronised - Feature: [OpenRCT2#5970] The Bobsleigh Roller Coaster now supports on-ride photos. - Feature: [OpenRCT2#5991] Allow all tracked rides that can be tested without guests to the Track Designer - Fix: [OpenRCT2#2127, OpenRCT2#2229, OpenRCT2#5586] Mountain tool cost calculation - Fix: [OpenRCT2#3589] Crash due to invalid footpathEntry in path_paint - Fix: [OpenRCT2#3852] Constructing path not clearing scenery on server. - Fix: [OpenRCT2#4455] Crash in window_sign_invalidate due to original bug - Fix: [OpenRCT2#4715] Fix OpenGL rendering of water when zoomed. See OpenRCT2#5890. - Fix: [OpenRCT2#4931] Crash in path_paint - footpathentry was null - Fix: [OpenRCT2#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity - Fix: [OpenRCT2#5768] Prevent loading non-existent title sequences. - Fix: [OpenRCT2#5858] Crash when using custom ride with no colour presets. - Fix: [OpenRCT2#5865] Ride preview flickering on uneven terrain or mid air. - Fix: [OpenRCT2#5872] Incorrect OpenGL rendering of masked sprites - Fix: [OpenRCT2#5880] Leaving bumper cars without building causes assertion. - Fix: [OpenRCT2#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours. - Fix: [OpenRCT2#5912] Negative queue when moving entrance in paused state. - Fix: [OpenRCT2#5920] Placing guest spawn doesn't do anything every 3rd click - Fix: [OpenRCT2#5939] Crash when importing 'Six Flags Santa Fe'. - Fix: [OpenRCT2#5977] Custom music files not showing up in music list - Fix: [OpenRCT2#5981] Ride list doesn't update after using quick demolish. - Fix: [OpenRCT2#5984] Allow socket binding to same port after crash - Fix: [OpenRCT2#5998] Staff not getting paid / no loan interest. - Fix: [OpenRCT2#6026] 'Select ride to advertise' dropdown does not display all items. - Fix: [OpenRCT2#6052] Unable to place entrance/exit on certain ride types. - Fix: [OpenRCT2#6071] Quick demolish can delete protected ride. - Fix: [OpenRCT2#6111] Mute button always visible in editor. - Fix: [OpenRCT2#6113] Track preview shows incorrect highest drop height. - Improved: [OpenRCT2#2223] Change mountain tool to ignore higher surrounding tiles. - Improved: [OpenRCT2#4301] Leading and trailing whitespace in player name is now removed. - Improved: [OpenRCT2#5859] OpenGL rendering performance - Improved: [OpenRCT2#5863] Switching drawing engines no longer requires the application to restart. - Improved: [OpenRCT2#6003] Doors placed on tracks will now work with all vehicles - Improved: [OpenRCT2#6037] Autosaves are now stored in a subfolder - Improved: The land tool buttons can now be held down to increase/decrease size. - Improved: Dropdowns longer than 32 items overflow into columns. - Improved: Ride Type option in ride window is now a dropdown. - Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
janisozaur
added a commit
that referenced
this issue
Aug 9, 2017
- Feature: [#5815] Add cheat to ignore research status and access rides/scenery not yet invented. - Feature: [#5857] Keyboard shortcut for clear scenery. - Feature: [#5877] Allow up to 16 stations to be synchronised - Feature: [#5970] The Bobsleigh Roller Coaster now supports on-ride photos. - Feature: [#5991] Allow all tracked rides that can be tested without guests to the Track Designer - Fix: [#2127, #2229, #5586] Mountain tool cost calculation - Fix: [#3589] Crash due to invalid footpathEntry in path_paint - Fix: [#3852] Constructing path not clearing scenery on server. - Fix: [#4455] Crash in window_sign_invalidate due to original bug - Fix: [#4715] Fix OpenGL rendering of water when zoomed. See #5890. - Fix: [#4931] Crash in path_paint - footpathentry was null - Fix: [#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity - Fix: [#5768] Prevent loading non-existent title sequences. - Fix: [#5858] Crash when using custom ride with no colour presets. - Fix: [#5865] Ride preview flickering on uneven terrain or mid air. - Fix: [#5872] Incorrect OpenGL rendering of masked sprites - Fix: [#5880] Leaving bumper cars without building causes assertion. - Fix: [#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours. - Fix: [#5912] Negative queue when moving entrance in paused state. - Fix: [#5920] Placing guest spawn doesn't do anything every 3rd click - Fix: [#5939] Crash when importing 'Six Flags Santa Fe'. - Fix: [#5977] Custom music files not showing up in music list - Fix: [#5981] Ride list doesn't update after using quick demolish. - Fix: [#5984] Allow socket binding to same port after crash - Fix: [#5998] Staff not getting paid / no loan interest. - Fix: [#6026] 'Select ride to advertise' dropdown does not display all items. - Fix: [#6052] Unable to place entrance/exit on certain ride types. - Fix: [#6071] Quick demolish can delete protected ride. - Fix: [#6111] Mute button always visible in editor. - Fix: [#6113] Track preview shows incorrect highest drop height. - Improved: [#2223] Change mountain tool to ignore higher surrounding tiles. - Improved: [#4301] Leading and trailing whitespace in player name is now removed. - Improved: [#5859] OpenGL rendering performance - Improved: [#5863] Switching drawing engines no longer requires the application to restart. - Improved: [#6003] Doors placed on tracks will now work with all vehicles - Improved: [#6037] Autosaves are now stored in a subfolder - Improved: The land tool buttons can now be held down to increase/decrease size. - Improved: Dropdowns longer than 32 items overflow into columns. - Improved: Ride Type option in ride window is now a dropdown. - Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OS: Linux
Commit/Build: a808da9
Load the attached park, switch between renderers, observe the difference.
Software:
OpenGL:
Save game:
opengl.sv6.txt
The text was updated successfully, but these errors were encountered: