Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when importing 'Six Flags Santa Fe' #5939

Closed
spacek531 opened this issue Jul 18, 2017 · 1 comment
Closed

Crash when importing 'Six Flags Santa Fe' #5939

spacek531 opened this issue Jul 18, 2017 · 1 comment
Assignees
Labels
bug Something went wrong.

Comments

@spacek531
Copy link
Contributor

**OS:**8,1
Version: 0.1.0
Commit/Build: ca1aaec

OpenRCT2 crashes when trying to import this park: https://www.nedesigns.com/park/1925/six-flags-santa-fe

Here's some dumps:

crash opening park.zip

@IntelOrca IntelOrca added the bug Something went wrong. label Jul 18, 2017
@Nubbie
Copy link
Contributor

Nubbie commented Jul 18, 2017

Extracted from 4d99f46c-7856-47cb-9079-930ec8aaa4eb(ca1aaec_x86-64).dmp
Commit ca1aaec
https://openrct2.org/downloads/develop/ca1aaec

Error message;
Unhandled exception at 0x00007FF97EFB8F11 (openrct2.dll) in 4d99f46c-7856-47cb-9079-930ec8aaa4eb(ca1aaec_x86-64).dmp: 0xC0000005: Access violation writing location 0x0000000000000000.

Call stack;

>	openrct2.dll!Guard::Assert_VA(bool expression, const char * message=0x00007ff97f806930, char * args=0x0000005198dcf410) Line 119	C++
 	openrct2.dll!Guard::Assert(bool expression, const char * message=0x00007ff97f806930, ...) Line 81	C++
 	openrct2.dll!fix_invalid_vehicle_sprite_sizes(...) Line 8703	C
 	openrct2.dll!game_fix_save_vars(...) Line 1098	C
 	openrct2.dll!game_load_sv6_path(const char * path=0x0000005198dcf560) Line 456	C++
 	openrct2.dll!game_load_save(const char * path=0x0000005198dcf560) Line 1116	C
 	openrct2.dll!window_loadsave_select(rct_window * path=0x000000519fbcc3c0, const char *) Line 757	C
 	openrct2.dll!window_loadsave_scrollmousedown(rct_window * w=0x00007ff97fe9ee40, int scrollIndex=0, int x, int y) Line 402	C
 	openrct2.dll!input_widget_left(int x=442, int y=242, rct_window * w=0x00007ff97fe9ee40, short widgetIndex) Line 1011	C
 	openrct2.dll!game_handle_input_mouse(int x=442, int y=242, int state) Line 298	C
 	openrct2.dll!game_handle_input(...) Line 130	C
 	openrct2.dll!rct2_update(...) Line 435	C
 	openrct2.dll!OpenRCT2::Context::RunVariableFrame() Line 455	C++
 	openrct2.dll!OpenRCT2::Context::RunGameLoop() Line 381	C++
 	openrct2.dll!OpenRCT2::Context::RunOpenRCT2(int argc=-1728140816, char * * argv=0x0000000000000001) Line 136	C++
 	openrct2.dll!NormalisedMain(int argc=1, char * * argv=0x0000005198f89470) Line 65	C++
 	openrct2.dll!LaunchOpenRCT2(int argc, wchar_t * * argvW) Line 55	C++
 	[External Code]	

Locals at call stack line 2;

		expression	Variable is optimized away and not available.	
-		message	0x00007ff97f806930 "Tried getting sprite %u"	const char *
			84 'T'	const char

Locals at call stack line 3;

		i	28736	unsigned short
		ride	Variable is optimized away and not available.	
		rideSpriteIndex	Variable is optimized away and not available.	
		vehicle	Variable is optimized away and not available.	

@IntelOrca IntelOrca self-assigned this Jul 18, 2017
@IntelOrca IntelOrca changed the title crash when importing park Crash when importing 'Six Flags Santa Fe' Jul 18, 2017
ZehMatt pushed a commit to ZehMatt/OpenRCT2 that referenced this issue Jul 19, 2017
Protect fix_invalid_vehicle_sprite_sizes from invalid vehicle chains.
janisozaur added a commit to janisozaur/OpenRCT2 that referenced this issue Aug 9, 2017
- Feature: [OpenRCT2#5815] Add cheat to ignore research status and access rides/scenery not yet invented.
- Feature: [OpenRCT2#5857] Keyboard shortcut for clear scenery.
- Feature: [OpenRCT2#5877] Allow up to 16 stations to be synchronised
- Feature: [OpenRCT2#5970] The Bobsleigh Roller Coaster now supports on-ride photos.
- Feature: [OpenRCT2#5991] Allow all tracked rides that can be tested without guests to the Track Designer
- Fix: [OpenRCT2#2127, OpenRCT2#2229, OpenRCT2#5586] Mountain tool cost calculation
- Fix: [OpenRCT2#3589] Crash due to invalid footpathEntry in path_paint
- Fix: [OpenRCT2#3852] Constructing path not clearing scenery on server.
- Fix: [OpenRCT2#4455] Crash in window_sign_invalidate due to original bug
- Fix: [OpenRCT2#4715] Fix OpenGL rendering of water when zoomed. See OpenRCT2#5890.
- Fix: [OpenRCT2#4931] Crash in path_paint - footpathentry was null
- Fix: [OpenRCT2#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity
- Fix: [OpenRCT2#5768] Prevent loading non-existent title sequences.
- Fix: [OpenRCT2#5858] Crash when using custom ride with no colour presets.
- Fix: [OpenRCT2#5865] Ride preview flickering on uneven terrain or mid air.
- Fix: [OpenRCT2#5872] Incorrect OpenGL rendering of masked sprites
- Fix: [OpenRCT2#5880] Leaving bumper cars without building causes assertion.
- Fix: [OpenRCT2#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours.
- Fix: [OpenRCT2#5912] Negative queue when moving entrance in paused state.
- Fix: [OpenRCT2#5920] Placing guest spawn doesn't do anything every 3rd click
- Fix: [OpenRCT2#5939] Crash when importing 'Six Flags Santa Fe'.
- Fix: [OpenRCT2#5977] Custom music files not showing up in music list
- Fix: [OpenRCT2#5981] Ride list doesn't update after using quick demolish.
- Fix: [OpenRCT2#5984] Allow socket binding to same port after crash
- Fix: [OpenRCT2#5998] Staff not getting paid / no loan interest.
- Fix: [OpenRCT2#6026] 'Select ride to advertise' dropdown does not display all items.
- Fix: [OpenRCT2#6052] Unable to place entrance/exit on certain ride types.
- Fix: [OpenRCT2#6071] Quick demolish can delete protected ride.
- Fix: [OpenRCT2#6111] Mute button always visible in editor.
- Fix: [OpenRCT2#6113] Track preview shows incorrect highest drop height.
- Improved: [OpenRCT2#2223] Change mountain tool to ignore higher surrounding tiles.
- Improved: [OpenRCT2#4301] Leading and trailing whitespace in player name is now removed.
- Improved: [OpenRCT2#5859] OpenGL rendering performance
- Improved: [OpenRCT2#5863] Switching drawing engines no longer requires the application to restart.
- Improved: [OpenRCT2#6003] Doors placed on tracks will now work with all vehicles
- Improved: [OpenRCT2#6037] Autosaves are now stored in a subfolder
- Improved: The land tool buttons can now be held down to increase/decrease size.
- Improved: Dropdowns longer than 32 items overflow into columns.
- Improved: Ride Type option in ride window is now a dropdown.
- Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
janisozaur added a commit that referenced this issue Aug 9, 2017
- Feature: [#5815] Add cheat to ignore research status and access rides/scenery not yet invented.
- Feature: [#5857] Keyboard shortcut for clear scenery.
- Feature: [#5877] Allow up to 16 stations to be synchronised
- Feature: [#5970] The Bobsleigh Roller Coaster now supports on-ride photos.
- Feature: [#5991] Allow all tracked rides that can be tested without guests to the Track Designer
- Fix: [#2127, #2229, #5586] Mountain tool cost calculation
- Fix: [#3589] Crash due to invalid footpathEntry in path_paint
- Fix: [#3852] Constructing path not clearing scenery on server.
- Fix: [#4455] Crash in window_sign_invalidate due to original bug
- Fix: [#4715] Fix OpenGL rendering of water when zoomed. See #5890.
- Fix: [#4931] Crash in path_paint - footpathentry was null
- Fix: [#5629] Issue with tower ride modes approach to station - incorrect sum caused sawtooth in velocity
- Fix: [#5768] Prevent loading non-existent title sequences.
- Fix: [#5858] Crash when using custom ride with no colour presets.
- Fix: [#5865] Ride preview flickering on uneven terrain or mid air.
- Fix: [#5872] Incorrect OpenGL rendering of masked sprites
- Fix: [#5880] Leaving bumper cars without building causes assertion.
- Fix: [#5890] Fix zoomed OpenGL rendering of special sprites with primary and secondary colours.
- Fix: [#5912] Negative queue when moving entrance in paused state.
- Fix: [#5920] Placing guest spawn doesn't do anything every 3rd click
- Fix: [#5939] Crash when importing 'Six Flags Santa Fe'.
- Fix: [#5977] Custom music files not showing up in music list
- Fix: [#5981] Ride list doesn't update after using quick demolish.
- Fix: [#5984] Allow socket binding to same port after crash
- Fix: [#5998] Staff not getting paid / no loan interest.
- Fix: [#6026] 'Select ride to advertise' dropdown does not display all items.
- Fix: [#6052] Unable to place entrance/exit on certain ride types.
- Fix: [#6071] Quick demolish can delete protected ride.
- Fix: [#6111] Mute button always visible in editor.
- Fix: [#6113] Track preview shows incorrect highest drop height.
- Improved: [#2223] Change mountain tool to ignore higher surrounding tiles.
- Improved: [#4301] Leading and trailing whitespace in player name is now removed.
- Improved: [#5859] OpenGL rendering performance
- Improved: [#5863] Switching drawing engines no longer requires the application to restart.
- Improved: [#6003] Doors placed on tracks will now work with all vehicles
- Improved: [#6037] Autosaves are now stored in a subfolder
- Improved: The land tool buttons can now be held down to increase/decrease size.
- Improved: Dropdowns longer than 32 items overflow into columns.
- Improved: Ride Type option in ride window is now a dropdown.
- Improved: "About OpenRCT2" window redesigned, now contains OpenRCT2 info and access to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

No branches or pull requests

3 participants