Add "Ignore research status" cheat

[wolfreak99]

For a long time I've attempted to make a cheat that would invent all the items, to be used over multiplayer. Despite numerous attempts, I can't seem to grasp the algorithm of the research list. Errors happen, list doesn't organize right, infinite loops, etc. It recently hit me that it could be handled indirectly by having the windows (the only areas the invention status is checked) ignore the status, that way the research list is not actually affected.

This does not reload the windows, however. That will need to be done manually. This is to preserve scroll positions and also prevent someone on multiplayer from enabling/disabling the cheat and throwing off someones click.

[Gymnasiast]

Rather than adding checks everywhere, wouldn't it be a better idea to have ride_type_is_invented() always return true when in this mode?

[wolfreak99]

@Gymnasiast for the sake of stability, i chose to avoid adding the checks inside the research.c (such as here ). if i were to have ride_type_invented check the cheats mode, would i be able to modify it to be ride_type_is_invented(sint32 type, bool bypassCheat) or something of that sort?

Or i could rewrite
bool ride_type_is_invented(sint32 type)
to

bool ride_type_is_invented(sint32 type) { return ride_type_is_invented_ext(type, false); }

that way the portions inside research.c can just check ride_type_is_invented_ext(type, true)

[Gymnasiast]

Hm, good point. I'll have to think about this.

[wolfreak99]

@Gymnasiast I apologize about the multiple pushing spam, I was trying to fix something and i kept forgetting to amend the message etc.

But i did change it to how you suggested so it won't effect too many files. The main issue I was worried about is it being also read inside research_finish_item, I don't want to break anything so I did add a temporary disable to the cheat inside there to be safe. It makes sense to listen to the cheats when attempting to build a new ride, but not while it's actually performing the research. I really hope i'm making sense right now, my mind is really scattered at the second from these pain killers

[Gymnasiast]

On second thought, your initial solution might be better after all - it played safer. Sorry for the U-turn on this.
Could you drop the last commit and rebase this?