Use child cap or scale consistently for MA dependent credits - #1112
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
- Coverage 95.47% 95.47% -0.01%
==========================================
Files 701 701
Lines 12540 12539 -1
Branches 904 904
==========================================
- Hits 11972 11971 -1
Misses 533 533
Partials 35 35
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1087
The scale parameter was closer to the law, but:
a) PolicyEngine doesn't display scale parameters
b) Several have proposed lifting the cap, which is simpler with a cap than scale parameter, even if we could display it
So I switched it to a cap/dependent structure.