Skip to content

Show stopped cloud tasks as completed#3697

Merged
trunk-io[bot] merged 4 commits into
mainfrom
posthog-code/neutral-stopped-cloud-task-status
Jul 22, 2026
Merged

Show stopped cloud tasks as completed#3697
trunk-io[bot] merged 4 commits into
mainfrom
posthog-code/neutral-stopped-cloud-task-status

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Problem

Stopping a cloud task is an intentional user action, but the sidebar currently presents it with the same red treatment as a failed run.

Why: Stopped tasks should read as successfully finished rather than errors that need attention.

Changes

Render cancelled cloud runs with the same filled green cloud as completed runs, labelled “stopped”, while preserving the red treatment for genuine failures

Generated-By: PostHog Code
Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
@trunk-io

trunk-io Bot commented Jul 22, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

React Doctor found 1 issue in 1 file · 1 warning.

1 warning

src/features/sidebar/components/items/TaskIcon.tsx

Reviewed by React Doctor for commit f683cdf.

@tatoalo tatoalo self-assigned this Jul 22, 2026
Generated-By: PostHog Code
Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
@tatoalo tatoalo changed the title Show stopped cloud tasks with a neutral status Show stopped cloud tasks as completed Jul 22, 2026
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 22, 2026
@tatoalo
tatoalo marked this pull request as ready for review July 22, 2026 12:03
@tatoalo
tatoalo enabled auto-merge (squash) July 22, 2026 12:03
Generated-By: PostHog Code
Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/ui/src/features/sidebar/components/items/TaskIcon.tsx:164-166
**Stopped Status Lacks Accessible Distinction**

When a cancelled run has a link, this branch now renders exactly like a completed run while `ariaLabel` only announces “Open … thread”; without a link, the icon span has no accessible status label. Users who cannot rely on the tooltip or color therefore cannot determine that the run was stopped.

Reviews (1): Last reviewed commit: "Render sidebar icon helper as a componen..." | Re-trigger Greptile

Comment thread packages/ui/src/features/sidebar/components/items/TaskIcon.tsx Outdated
@stamphog

stamphog Bot commented Jul 22, 2026

Copy link
Copy Markdown

Note

🤖 stamphog reviewed 424d45447d9c8fd50f0b693ffe064e5f207bb9ff — verdict: REFUSED

Greptile's unresolved comment flags a real accessibility gap directly in the feature being changed: stopped runs become visually indistinguishable from completed ones, but the aria-label/status text isn't updated to say "stopped" for screen-reader users (with or without a link). That's a substantive, unaddressed concern on the exact behavior this PR introduces, not a style nit.

  • greptile-apps[bot] reviewed the current head.
  • Unresolved Greptile inline comment: cancelled/stopped runs render identically to completed runs but lack an accessible status label distinguishing 'stopped' from 'completed', both when a thread link is present (ariaLabel still says 'Open ... thread') and when it isn't (icon span has no status label at all).
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 84L, 1F substantive — within ceiling
tier T1-agent / T1b-small (84L, 1F, single-area, unknown)
stamphog 2.0.0b3 .stamphog/policy.yml @ 92db230 · reviewed head 424d454

Updated in place — this replaces 1 earlier stamphog review(s) on this PR.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 22, 2026
Generated-By: PostHog Code
Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 22, 2026 — with PostHog

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contained, low-risk UI change to sidebar task icon rendering; the accessibility gap Greptile flagged is visibly fixed in the current diff (status-aware aria-labels/role="img" added) and the reviewer's own 👍 corroborates.

  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 101L, 1F substantive — within ceiling
tier T1-agent / T1c-medium (101L, 1F, single-area, unknown)
stamphog 2.0.0b3 .stamphog/policy.yml @ 92db230 · reviewed head f683cdf

@PostHog PostHog deleted a comment from greptile-apps Bot Jul 22, 2026
@trunk-io
trunk-io Bot merged commit 0928b15 into main Jul 22, 2026
38 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/neutral-stopped-cloud-task-status branch July 22, 2026 12:19
Gilbert09 added a commit that referenced this pull request Jul 23, 2026
Ports the desktop fix (#3697) to the mobile app. A cloud run the user
deliberately stops (backend status `cancelled`) was being collapsed into
`failed`, so the end-of-run banner read "Run failed" with a Retry button.

Map `cancelled` to a new terminal outcome `stopped`: the banner now reads
"Run stopped" with neutral/success styling and offers Continue. Introduces a
shared `TerminalStatus` type and extracts the banner into
`TerminalStatusBanner` for isolated testing.

Generated-By: PostHog Code
Task-Id: 880d3028-60e8-4893-b5f6-2b31f4a44456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant