Show stopped cloud tasks as completed#3697
Conversation
Generated-By: PostHog Code Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
Generated-By: PostHog Code Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/sidebar/components/items/TaskIcon.tsx:164-166
**Stopped Status Lacks Accessible Distinction**
When a cancelled run has a link, this branch now renders exactly like a completed run while `ariaLabel` only announces “Open … thread”; without a link, the icon span has no accessible status label. Users who cannot rely on the tooltip or color therefore cannot determine that the run was stopped.
Reviews (1): Last reviewed commit: "Render sidebar icon helper as a componen..." | Re-trigger Greptile |
|
Note 🤖 stamphog reviewed Greptile's unresolved comment flags a real accessibility gap directly in the feature being changed: stopped runs become visually indistinguishable from completed ones, but the aria-label/status text isn't updated to say "stopped" for screen-reader users (with or without a link). That's a substantive, unaddressed concern on the exact behavior this PR introduces, not a style nit.
Gate mechanics and policy version
Updated in place — this replaces 1 earlier stamphog review(s) on this PR. |
Generated-By: PostHog Code Task-Id: e71bcaa1-6a25-47c7-b878-2eddb5e77a8e
There was a problem hiding this comment.
Contained, low-risk UI change to sidebar task icon rendering; the accessibility gap Greptile flagged is visibly fixed in the current diff (status-aware aria-labels/role="img" added) and the reviewer's own 👍 corroborates.
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 101L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (101L, 1F, single-area, unknown) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 92db230 · reviewed head f683cdf |
Ports the desktop fix (#3697) to the mobile app. A cloud run the user deliberately stops (backend status `cancelled`) was being collapsed into `failed`, so the end-of-run banner read "Run failed" with a Retry button. Map `cancelled` to a new terminal outcome `stopped`: the banner now reads "Run stopped" with neutral/success styling and offers Continue. Introduces a shared `TerminalStatus` type and extracts the banner into `TerminalStatusBanner` for isolated testing. Generated-By: PostHog Code Task-Id: 880d3028-60e8-4893-b5f6-2b31f4a44456
Problem
Stopping a cloud task is an intentional user action, but the sidebar currently presents it with the same red treatment as a failed run.
Why: Stopped tasks should read as successfully finished rather than errors that need attention.
Changes
Render cancelled cloud runs with the same filled green cloud as completed runs, labelled “stopped”, while preserving the red treatment for genuine failures