Skip to content

Show stopped cloud tasks as completed #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 4 commits into from
Jul 22, 2026
+63 −38
Merged

Show stopped cloud tasks as completed #3697

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9088ea7
Show stopped cloud tasks with a neutral status
tatoalo Jul 22, 2026
6c60f6b
Use completed styling for stopped cloud tasks
tatoalo Jul 22, 2026
424d454
Render sidebar icon helper as a component
tatoalo Jul 22, 2026
f683cdf
Add accessible stopped task status
tatoalo Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 63 additions & 38 deletions packages/ui/src/features/sidebar/components/items/TaskIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function getOriginProductMeta(
// clickable NestedButton that opens the originating thread externally.
// SidebarItem renders the row as a `<button>`, so a real `<a>` or a nested
// `<button>` here would be invalid HTML.
function renderIconSpan({
function IconSpan({
icon,
link,
ariaLabel,
Expand All @@ -72,7 +72,18 @@ function renderIconSpan({
ariaLabel?: string;
}) {
if (!link) {
return <span className="flex items-center justify-center">{icon}</span>;
if (!ariaLabel) {
return <span className="flex items-center justify-center">{icon}</span>;
}
return (
<span
aria-label={ariaLabel}
className="flex items-center justify-center"
role="img"
>
{icon}
</span>
);
}
return (
<NestedButton
Expand Down Expand Up @@ -112,11 +123,11 @@ function CloudStatusIcon({
}
side="right"
>
{renderIconSpan({
icon: <Icon size={size} className="ph-pulse" />,
link,
ariaLabel,
})}
<IconSpan
icon={<Icon size={size} className="ph-pulse" />}
link={link}
ariaLabel={ariaLabel}
/>
</Tooltip>
);
}
Expand All @@ -128,11 +139,11 @@ function CloudStatusIcon({
}
side="right"
>
{renderIconSpan({
icon: <Icon size={size} weight="fill" color="var(--accent-11)" />,
link,
ariaLabel,
})}
<IconSpan
icon={<Icon size={size} weight="fill" color="var(--accent-11)" />}
link={link}
ariaLabel={ariaLabel}
/>
</Tooltip>
);
}
Expand All @@ -144,29 +155,47 @@ function CloudStatusIcon({
}
side="right"
>
{renderIconSpan({
icon: <Icon size={size} weight="fill" color="var(--green-11)" />,
link,
ariaLabel,
})}
<IconSpan
icon={<Icon size={size} weight="fill" color="var(--green-11)" />}
link={link}
ariaLabel={ariaLabel}
/>
</Tooltip>
);
}
if (taskRunStatus === "cancelled") {
return (
<Tooltip
content={
link ? `Open ${sourceLabel} thread` : `${sourceLabel} (stopped)`
}
side="right"
>
<IconSpan
icon={<Icon size={size} weight="fill" color="var(--green-11)" />}
link={link}
ariaLabel={
link
? `Open ${sourceLabel} thread (stopped)`
: `${sourceLabel} (stopped)`
}
/>
</Tooltip>
);
}
if (taskRunStatus === "failed" || taskRunStatus === "cancelled") {
const statusLabel =
taskRunStatus === "cancelled"
? `${sourceLabel} (cancelled)`
: `${sourceLabel} (failed)`;
if (taskRunStatus === "failed") {
return (
<Tooltip
content={link ? `Open ${sourceLabel} thread` : statusLabel}
content={
link ? `Open ${sourceLabel} thread` : `${sourceLabel} (failed)`
}
side="right"
>
{renderIconSpan({
icon: <Icon size={size} weight="fill" color="var(--red-11)" />,
link,
ariaLabel,
})}
<IconSpan
icon={<Icon size={size} weight="fill" color="var(--red-11)" />}
link={link}
ariaLabel={ariaLabel}
/>
</Tooltip>
);
}
Expand All @@ -175,11 +204,7 @@ function CloudStatusIcon({
content={link ? `Open ${sourceLabel} thread` : sourceLabel}
side="right"
>
{renderIconSpan({
icon: <Icon size={size} />,
link,
ariaLabel,
})}
<IconSpan icon={<Icon size={size} />} link={link} ariaLabel={ariaLabel} />
</Tooltip>
);
}
Expand Down Expand Up @@ -351,11 +376,11 @@ export function TaskIcon({
content={link ? `Open ${label} thread` : `From ${label}`}
side="right"
>
{renderIconSpan({
icon: <Icon size={size} color="var(--gray-10)" />,
link,
ariaLabel: `Open ${label} thread`,
})}
<IconSpan
icon={<Icon size={size} color="var(--gray-10)" />}
link={link}
ariaLabel={`Open ${label} thread`}
/>
</Tooltip>
);
}
Expand Down
Loading