Remove the usage of is_simple_flag
#186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's no longer used anywhere.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR removes the unused is_simple_flag attribute from feature flag definitions in test files, focusing on code cleanup without impacting functionality.
- Removed
is_simple_flagattribute from test data in/posthog/test/test_client.py - Removed
is_simple_flagattribute from test data in/posthog/test/test_feature_flags.py - All tests continue to pass as the attribute was not used in any logical evaluations
- Feature flag behavior remains unchanged, still evaluating based on core properties like
active,filters,groups, androllout_percentage
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
havenbarnes
approved these changes
Feb 11, 2025
Contributor
havenbarnes
left a comment
havenbarnes
left a comment
There was a problem hiding this comment.
This makes sense to me - thoughts on removing the column with a django migration?
Collaborator
Author
I'll look into that. I wanted to remove it from the client tests first. |
Collaborator
Author
The good news is it's not a column on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer used anywhere. This is just cleanup code.