chore(replay-vision): replace indexer scanner with summarizer facets#60442
Merged
Conversation
Contributor
MCP UI Apps size report
|
Contributor
|
Size Change: 0 B Total Size: 80.7 MB ℹ️ View Unchanged
|
TueHaulund
force-pushed
the
tue/replay-vision-consolidation
branch
2 times, most recently
from
8d52716 to
d7eef90
Compare
Contributor
Migration SQL ChangesHey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:
|
Contributor
🔍 Migration Risk AnalysisWe've analyzed your migrations for potential risks. Summary: 0 Safe | 2 Needs Review | 0 Blocked
|
The summarizer scanner now produces optional facets (intent, outcome, friction_points, keywords) alongside title and summary. When the `emits_embeddings` flag is set in scanner_config, the prompt instructs the model to fill the facets and the workflow dispatches the embedding side-effect activity. The activity is gated by three guards: scanner output is SummarizerOutput, flag is set, and at least one facet has content. The dedicated indexer scanner type is removed entirely; existing indexer scanners and observations are deleted by the migration.
TueHaulund
force-pushed
the
tue/replay-vision-consolidation
branch
from
39e513b to
8e32797
Compare
TueHaulund
requested review from
a team,
arnohillen,
fasyy612,
ksvat and
nicowaltz
and removed request for
a team
Contributor
|
Reviews (1): Last reviewed commit: "chore: update OpenAPI generated types" | Re-trigger Greptile |
ksvat
approved these changes
May 29, 2026
Gilbert09
added a commit
that referenced
this pull request
May 29, 2026
PR #60442 ("replace indexer scanner with summarizer facets") dropped the `indexer` value from `ScannerType` and the `IndexerScannerConfig` export in `types.ts`, but left the matching `IndexerTemplate` interface, union member, and import in `scannerTemplates.ts`. That broke `tsc --strict` on master (and every PR that touches frontend). This removes the dead references so the union narrows to the four remaining template kinds, which also unblocks the `scannerTypeLabel` call site in `ScannerTemplatesScene.tsx`. Generated-By: PostHog Code Task-Id: b030b433-e0f1-4871-baf1-59fcdb6f4f32
Gilbert09
added a commit
that referenced
this pull request
May 29, 2026
PR #60442 added a required `emits_embeddings: boolean` field to `SummarizerScannerConfig` but left the session_summary entry in `defaultScannerTemplates` without it, so strict tsc rejected the template. Default to `false` to match the backend serializer's default behaviour (`scanner_config.get("emits_embeddings", False)`). Generated-By: PostHog Code Task-Id: b030b433-e0f1-4871-baf1-59fcdb6f4f32
2 tasks
TueHaulund
added a commit
that referenced
this pull request
May 30, 2026
- Remove the obsolete IndexerTemplate / IndexerScannerConfig import from scannerTemplates.ts; the indexer scanner type was removed in #60442. - Add the now-required `emits_embeddings: false` field to the session_summary template's scanner_config (matches the updated SummarizerScannerConfig). - Reformat the Reasoning CitedText invocation in ReplayObservation.tsx so oxfmt is happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The indexer scanner duplicated most of the summarizer (LLM-summarize a session) just to emit facet embeddings as a side effect.
Changes
Indexer is removed. Summarizers gain an opt-in
emits_embeddingsflag inscanner_config. When set, the LLM is called against an extended response schema withintent/outcome/friction_points/keywords, the prompt asks for them, and the workflow dispatches the embedding side-effect activity. When off, the LLM sees only the lean title/summary schema.Existing indexer scanners and observations are deleted by the migration (closed beta).
How did you test this code?
Agent-authored. Automated only:
hogli test products/replay_vision/backend/tests/(231 passed),replayScannerLogic.test.ts(14 passed),hogli build:openapiclean,tscclean on touched files. No manual UI testing.Publish to changelog?
no
🤖 Agent context
Tool: Claude Code.