chore(replay-vision): remove dead indexer types from frontend#60770
Merged
Conversation
The indexer scanner was removed from the backend in #60442 (migrations 0008/0009 drop the choice and delete any rows). A follow-up hotfix #60751 re-added `IndexerScanner` / `IndexerScannerConfig` and `'indexer'` to the `ScannerType` union purely to unblock master after the consolidation PR landed. Nothing in the codebase references those types any more — verified with a repo-wide grep across products/, services/, and frontend/src/. The only surviving `indexer` strings are the historical migrations themselves. Drop the dead types so the frontend matches the backend reality. Verified locally with `pnpm typescript:check` (no new errors introduced beyond the pre-existing local-env module-resolution noise that also fires on master) and the replay_vision jest suite (25 passing).
Contributor
|
Hey @TueHaulund! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
Contributor
|
Size Change: 0 B Total Size: 80.8 MB ℹ️ View Unchanged
|
TueHaulund
requested review from
a team,
arnohillen,
fasyy612,
ksvat and
nicowaltz
and removed request for
a team
Contributor
|
✅ Visual changes approved by @TueHaulund — baseline updated in 5 changed. |
5 updated Run: 6aba892e-8533-47e9-ae8a-333c601da8d2 Co-authored-by: TueHaulund <2675352+TueHaulund@users.noreply.github.com>
Contributor
|
Reviews (1): Last reviewed commit: "chore(visual): update storybook baseline..." | Re-trigger Greptile |
pauldambra
approved these changes
May 30, 2026
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
indexerscanner was removed in #60442 (backend migrations 0008/0009 drop the choice and delete any existing rows). The follow-up hotfix #60751 re-added'indexer'toScannerType, plusIndexerScannerConfigandIndexerScanner, purely to unblock master after #60442 landed without updating the consuming type/usages.After #60605 stripped the last actual consumer (the
IndexerScannerConfigimport inscannerTemplates.ts), those types are dead — there are no remaining references anywhere in the codebase outside the historical migrations.Changes
Drop the dead types from
products/replay_vision/frontend/replay_scanners/types.ts:'indexer'from theScannerTypeunion.IndexerScannerConfiginterface and its membership inScannerConfig.IndexerScannerinterface and its membership inReplayScanner.Net diff is one file, +2/-13.
How did you test this code?
Agent-authored. Automated only:
products/,services/,frontend/src/) that nothing other thantypes.tsitself and the historical backend migrations referencesindexer/Indexer/IndexerScanner/IndexerScannerConfig.pnpm typescript:checkintroduces no new replay_vision errors. The remaining errors (posthog-js,react-window,@posthog/products-error-tracking/frontend/utilsnot found) also fire on a clean checkout of master and are unrelated local-env module resolution noise.pnpm jest products/replay_vision/— 2 suites, 25 tests, all passing.oxlintclean on the touched file.No manual UI testing — pure type-only cleanup with no runtime change.
Publish to changelog?
no
🤖 Agent context
Tool: Claude Code (Opus). Single-file revert of the
indexerre-introduction from #60751, now that #60605 removed the last consumer and the situation is stable. Pre-flight grep was the safety step missed when #60442 first broke master.