fix(replay_vision): add indexer to ScannerType union and export IndexerScannerConfig#60751
Merged
Merged
Conversation
…erScannerConfig PR #60442 introduced the indexer scanner type and templates but did not update the type definitions in types.ts, causing TypeScript strict check failures on master (TS2322 and TS2300).
Contributor
|
Size Change: 0 B Total Size: 80.8 MB ℹ️ View Unchanged
|
pauldambra
approved these changes
May 29, 2026
assign-reviewers-posthog
Bot
requested review from
a team,
TueHaulund,
arnohillen,
fasyy612,
ksvat and
nicowaltz
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5cd0f3fb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
|
Reviews (1): Last reviewed commit: "fix(replay_vision): add missing emits_em..." | Re-trigger Greptile |
…ckend supports it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indexerscanner type without updating the type definitions intypes.ts.'indexer'to theScannerTypeunion, exportsIndexerScannerConfiginterface, addsIndexerScannerto theReplayScannerunion, and adds the indexer option toSCANNER_TYPE_OPTIONS.Fixes https://app.mendral.com/insights/01KSTVXFWWB71REJBN12FD1A9K
Note
Created by Mendral. Tag @mendral-app with feedback or questions.