feat(dashboards): add dashboard tile widget_id column (2/11)#60490
Merged
MattPua merged 6 commits intoMay 29, 2026
Conversation
Member
Author
This was referenced May 28, 2026
Closed
Closed
MattPua
changed the base branch from
05-28-chore_dashboards_add_dashboardwidget_model_and_table_migration
to
graphite-base/60490
Contributor
Migration SQL ChangesHey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:
|
MattPua
force-pushed
the
graphite-base/60490
branch
from
4206a12 to
416a5ab
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_tile_widget_id_column
branch
from
4106013 to
2e1437e
Compare
MattPua
changed the base branch from
graphite-base/60490
to
05-28-chore_dashboards_add_dashboardwidget_model_and_table_migration
Contributor
🔍 Migration Risk AnalysisWe've analyzed your migrations for potential risks. Summary: 1 Safe | 0 Needs Review | 0 Blocked ✅ SafeBrief or no lock, backwards compatible 📚 How to Deploy These Changes SafelyRunSQL: Follow up with VALIDATE CONSTRAINT in a later migration to check existing rows. Last updated: 2026-05-29 15:28 UTC (ab7d937) |
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
Query snapshots: Backend query snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Contributor
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
MattPua
changed the title
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_tile_widget_id_column
branch
from
b7d107b to
841eda7
Compare
Contributor
Query snapshots: Backend query snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_tile_widget_id_column
branch
from
10c1b05 to
841eda7
Compare
This was referenced May 28, 2026
Closed
This was referenced May 28, 2026
MattPua
changed the title
Contributor
Query snapshots: Backend query snapshots updatedChanges: 4 snapshots (4 modified, 0 added, 0 deleted) What this means:
Next steps:
|
MattPua
changed the title
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_tile_widget_id_column
branch
from
8b93bc3 to
1ac691f
Compare
Contributor
Query snapshots: Backend query snapshots updatedChanges: 4 snapshots (4 modified, 0 added, 0 deleted) What this means:
Next steps:
|
vdekrijger
approved these changes
May 29, 2026
Base automatically changed from
05-28-chore_dashboards_add_dashboardwidget_model_and_table_migration
to
master
May 29, 2026 13:28
Index is created concurrently in 0011; AddField state must match the model's db_index=False or makemigrations --check fails. Co-authored-by: Cursor <cursoragent@cursor.com>
DashboardTileSerializer now includes the widget FK field once widget_id exists on the model. Co-authored-by: Cursor <cursoragent@cursor.com>
Defer widget from DashboardTile.clean() so model validation matches the 3-way DB check constraint until PR #60491 adds the 4-way constraint. Co-authored-by: Cursor <cursoragent@cursor.com>
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_tile_widget_id_column
branch
2 times, most recently
from
6422e40 to
4839e6e
Compare
Contributor
Query snapshots: Backend query snapshots updatedChanges: 4 snapshots (4 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Contributor
|
Size Change: 0 B Total Size: 80.8 MB ℹ️ View Unchanged
|
Member
Author
MattPua
deleted the
05-28-chore_dashboards_add_dashboard_tile_widget_id_column
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dashboard tiles must optionally reference a
DashboardWidget. We add the nullable FK column in its own PR so deploy can be verified before constraint/check migrations.This PR is 2/10 in the dashboard widgets Graphite stack.
Depends on: PR 1 (DashboardWidget table)
Changes
0008_dashboardtile_widget_id— adds nullablewidget_idtoposthog_dashboardtilewithNOT VALIDFKDashboardTile.widgetFK field in Django state (3-way exclusivity check unchanged)How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
no
Docs update
skip-inkeep-docs
🤖 Agent context
NOT VALIDto avoid immediate validation scan on deploy