feat(dashboards): show widget placeholders on shared dashboards (2/4)#61416
Open
MattPua wants to merge 3 commits into
Open
feat(dashboards): show widget placeholders on shared dashboards (2/4)#61416MattPua wants to merge 3 commits into
MattPua wants to merge 3 commits into
Conversation
2 tasks
Member
Author
Contributor
|
Size Change: 0 B Total Size: 81.9 MB ℹ️ View Unchanged
|
MattPua
changed the title
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Contributor
MCP UI Apps size report
|
MattPua
commented
Jun 3, 2026
MattPua
commented
Jun 3, 2026
Contributor
Query snapshots: Backend query snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
2 tasks
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
21793db to
d2240b2
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
76f8ee7 to
a1c1dd4
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
2 times, most recently
from
b137596 to
ca59292
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
2 times, most recently
from
d3bef03 to
8366665
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
b4873e0 to
468a466
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
8366665 to
0085ca4
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
828da32 to
347310e
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
806c910 to
43d7f27
Compare
2 tasks
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
43d7f27 to
aef4ae0
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
347310e to
0cd448c
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
aef4ae0 to
f2fd850
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
0cd448c to
14747b7
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
|
🎭 Playwright report ❌ 1 failed test:
These issues are not necessarily caused by your changes. |
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
14747b7 to
7487807
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
f2fd850 to
5db6283
Compare
MattPua
changed the title
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
5db6283 to
c135069
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
0c6503e to
7487807
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
c135069 to
48f528e
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
48f528e to
016ac59
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
d0d0028 to
8fd6c0b
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
016ac59 to
9a6603f
Compare
MattPua
force-pushed
the
05-28-chore_dashboards_add_dashboard_widgets_docs
branch
from
8fd6c0b to
508fec9
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
Query snapshots: Backend query snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Base automatically changed from
05-28-chore_dashboards_add_dashboard_widgets_docs
to
master
June 3, 2026 22:15
vdekrijger
approved these changes
Jun 4, 2026
Contributor
vdekrijger
left a comment
vdekrijger
left a comment
There was a problem hiding this comment.
LGTM! I think you got hit by the same "stack issues" I had with some of my branches where it somehow includes previous changes (skills / .md files in this case).
I ignored all those .md files (those are from the earlier PR either way) and just reviewed the rest which looks good to me :D
Co-authored-by: Cursor <cursoragent@cursor.com>
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
c46fb2e to
e0624ac
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shared dashboards previously hid widget tiles entirely or showed empty space. Viewers couldn't see that a dashboard includes error tracking or session replay widgets, and the frontend still attempted widget data fetches that shared pages cannot satisfy.
Changes
id,widget_type,name,description,config) — no user fields or query resultsrun_widgetsfetches on Public/Export placements; enable widget rendering on shared pages when tile metadata is present (shared pages don't receive team feature flags)How did you test this code?
Automated tests (agent-authored; no manual browser verification in this session):
dashboardLogic.test.ts— public placement skips widget fetch; widgets enabled when tile metadata presentDashboardWidgetItem.test.tsx— shared placeholder renders per-widget copytest_dashboard_widgets.py::test_shared_dashboard_tile_serializer_omits_widget_payloadtest_sharing.py::TestSharedCohortInlining::test_shared_dashboard_includes_widget_metadata_only👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No docs changes in this PR — behavior is additive for shared dashboard rendering.
🤖 Agent context
Agent-assisted PR (Cursor). Builds on the dashboard widget stack (error tracking + session replay widgets).
Key decisions:
SharingViewSetwithis_shared=True; removed dead share-token guards onDashboardsViewSetthat could never firedashboard-widgetsfeature flag when exported tile metadata exists, since shared exports don't include team feature flagsKnown follow-up (not in this PR): widget/insight tiles with overlapping grid coordinates may render in a different visual order on shared dashboards vs the private editor.