feat(dashboards): add slo for widget data delivery (3/4)#61431
Open
MattPua wants to merge 1 commit into
Open
Conversation
MattPua
changed the base branch from
master
to
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
55992e5 to
28aec47
Compare
This was referenced Jun 3, 2026
Member
Author
MattPua
changed the title
Contributor
MCP UI Apps size report
|
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
7ea3fdd to
f333b9f
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
2 times, most recently
from
dbd677b to
b137596
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
f333b9f to
b5a3124
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
b137596 to
ca59292
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
b5a3124 to
999ad3c
Compare
Contributor
|
Size Change: 0 B Total Size: 81.9 MB ℹ️ View Unchanged
|
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
b4873e0 to
468a466
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
9f654c7 to
a5c395c
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
806c910 to
43d7f27
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
fcf8a71 to
2484fe6
Compare
2 tasks
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
43d7f27 to
aef4ae0
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
2484fe6 to
285d4bc
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
aef4ae0 to
f2fd850
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
285d4bc to
72f9878
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
f2fd850 to
5db6283
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
72f9878 to
504e583
Compare
MattPua
changed the title
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
5db6283 to
c135069
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
2 times, most recently
from
65b7b63 to
a17b4ab
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
c135069 to
48f528e
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
a17b4ab to
6f79ef2
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
2 times, most recently
from
016ac59 to
9a6603f
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
6f79ef2 to
4a0a6c3
Compare
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
Query snapshots: Backend query snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
vdekrijger
approved these changes
Jun 4, 2026
| WHERE and(equals(events.team_id, 99999), ifNull(equals(if(not(empty(events__override.distinct_id)), events__override.person_id, events.person_id), '00000000-0000-0000-0000-000000000000'), 0), lessOrEquals(events.timestamp, toDateTime64(toDateTime64('today', 6, 'UTC'), 6, 'UTC')), greaterOrEquals(events.timestamp, toDateTime64('explicit_redacted_timestamp', 6, 'UTC')), lessOrEquals(events.timestamp, toDateTime64('today', 6, 'UTC')), notEmpty(replaceRegexpAll(nullIf(nullIf(JSONExtractRaw(events.properties, '$session_id'), ''), 'null'), '^"|"$', ''))))), greaterOrEquals(s.min_first_timestamp, toDateTime64('explicit_redacted_timestamp', 6, 'UTC')), lessOrEquals(s.min_first_timestamp, toDateTime64('today', 6, 'UTC'))) | ||
| GROUP BY s.session_id | ||
| HAVING and(ifNull(greaterOrEquals(expiry_time, toDateTime64('today', 6, 'UTC')), 0), ifNull(equals(max(s.is_deleted), 0), 0)) | ||
| ORDER BY start_time DESC, |
Contributor
There was a problem hiding this comment.
I think this AMBR is a flakiness / red herring thing, I presume that a merge from master will fix this in due time, as I don't see how these changes can be caused by this PR 😃. Might be good to double check before doing the final merge though.
MattPua
force-pushed
the
06-03-feat_dashboards_show_widget_placeholders_on_shared_dashboards
branch
from
c46fb2e to
e0624ac
Compare
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
5a5a735 to
26e655d
Compare
Emit dashboard_widget_delivery slo_operation events from run_widgets with widget_type, dashboard_id, and tile_id so delivery success is trackable per widget type on the analytics platform SLO dashboard. Co-authored-by: Cursor <cursoragent@cursor.com>
MattPua
force-pushed
the
06-03-feat_dashboards_add_widget_delivery_slos
branch
from
26e655d to
a210144
Compare
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dashboard widgets fetch live data via
run_widgets, but we had no SLO coverage for whether that delivery succeeds — unlike subscriptions, alerts, and query service.Changes
SloOperation.DASHBOARD_WIDGET_DELIVERYand register it on the analytics platform SLO monitoring dashboard (99.95% target, US + EU)run_widgetswithslo_operation, taggingwidget_type,dashboard_id, andtile_idAccess/validation failures (missing tile, product access, API scope) are intentionally excluded — those are not platform delivery failures.
How did you test this code?
Automated tests (agent-authored):
posthog/slo/test/test_slo_context.py— existing SLO helper coveragetest_run_widgets.py::test_run_widgets_emits_slo_on_successful_widget_deliverytest_run_widgets.py::test_run_widgets_emits_slo_failure_when_widget_query_raises👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No docs changes — internal observability only.
🤖 Agent context
Agent-assisted PR (Cursor). Follows the same
slo_operationpattern as subscription create and query service, scoped to the actual widget query execution in_run_widget_queryso we can break down delivery reliability bywidget_typeon the existing SLO monitoring terraform dashboard.Made with Cursor