Skip to content

chore(frontend): inline Kea types batch 2 - #71456

Merged
mariusandra merged 6 commits into
masterfrom
posthog-code/typegen-inline-batch-02
Jul 16, 2026
Merged

chore(frontend): inline Kea types batch 2#71456
mariusandra merged 6 commits into
masterfrom
posthog-code/typegen-inline-batch-02

Conversation

@mariusandra

Copy link
Copy Markdown
Collaborator

Problem

The all-at-once Kea inline type migration is too large to merge safely while logic files keep changing.

Changes

  • Convert one balanced slice of Kea logics to inline MakeLogicType declarations.
  • Replace this batch’s reserved .kearc slots with its owned folders.
  • Keep this PR independent from the other conversion batches.

Note

Merge foundation PR #71446 first. This PR targets master rather than another batch, so sibling merges do not trigger stacked-PR restacks. Its shared foundation diff disappears after #71446 lands.

How did you test this code?

  • Generated from a single clean kea-typegen write --delete run that finished with all 1,040 logic types up to date.
  • Verified this branch contains only its assigned generated slice and reserved .kearc block.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

The shared contributor guidance is in #71446. No user-facing docs change is needed.

🤖 Agent context

Codex generated the full migration once on current master, partitioned changed files into nine balanced batches, and used preallocated .kearc slots to avoid sibling config conflicts.

Autonomy: Human-driven (agent-assisted)


Created with PostHog Code

@mariusandra mariusandra self-assigned this Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

Bundle size — 🟢 -19 B (-0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 64.79 MiB · 🟢 -19 B (-0.0%)

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.22 MiB · 22 files no change ███░░░░░░░ 28.4% of 4.29 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.14 MiB · 2,981 files no change █████████░ 87.9% of 9.25 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
281.3 KiB ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
235.5 KiB src/taxonomy/core-filter-definitions-by-group.json
222.9 KiB ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/module.js
164.0 KiB src/queries/validators.js
154.3 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.8 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.7 KiB ../packages/quill/packages/quill/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

Dist folder size — 🔺 +643.6 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1317.04 MiB · 🔺 +643.6 KiB (+0.0%)

Playwright — all passed

All tests passed.

View test results →

@pauldambra pauldambra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🎉

@trunk-io

trunk-io Bot commented Jul 16, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@mariusandra
mariusandra marked this pull request as ready for review July 16, 2026 09:41
@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review. (135 files found, 100 file limit)

Bypass the limit by tagging @greptile-apps to review.

@mariusandra
mariusandra enabled auto-merge (squash) July 16, 2026 09:41
@PostHog PostHog deleted a comment from github-actions Bot Jul 16, 2026
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested review from a team July 16, 2026 09:41
@pr-assigner-resolver-posthog

Copy link
Copy Markdown

👀 Auto-assigned reviewers

These soft owners were skipped because their changes are minor, or the reviewer list was getting long. Nothing blocks merge, so self-assign if you'd like a look:

  • @PostHog/team-product-analytics (frontend/src/scenes/owners.yaml)
  • @PostHog/conversations (products/business_knowledge/product.yaml)
  • @PostHog/team-growth (frontend/src/scenes/owners.yaml, products/growth/product.yaml)
  • @PostHog/team-data-tools (frontend/src/scenes/owners.yaml)
  • @PostHog/team-platform-features (products/links/product.yaml)
  • @PostHog/team-billing (frontend/src/scenes/owners.yaml)

Soft owners come from each directory's owners.yaml and each product's product.yaml (resolved nearest-file-wins). The locator after each owner is the file that decided it. Generated files and lockfiles are ignored when deciding ownership.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ❌ build failed

The preview didn't come up for commit 15fd559. See the build log for the failing step. It'll retry on the next push.

@carlos-marchal-ph
carlos-marchal-ph removed the request for review from a team July 16, 2026 12:40
@mariusandra
mariusandra force-pushed the posthog-code/typegen-inline-batch-02 branch from c7e4b41 to 671f961 Compare July 16, 2026 12:59
@github-actions
github-actions Bot requested a deployment to preview-pr-71456 July 16, 2026 12:59 In progress
Inline generated Kea types for the second balanced migration batch.

Generated-By: PostHog Code
Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code
Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code
Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Point AI observability consumers at the inlined logic export and sync stable generator output.

Generated-By: PostHog Code
Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code
Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
@mariusandra
mariusandra force-pushed the posthog-code/typegen-inline-batch-02 branch from 671f961 to 14fe3d5 Compare July 16, 2026 13:11
@github-actions
github-actions Bot requested a deployment to preview-pr-71456 July 16, 2026 13:11 In progress
Generated-By: PostHog Code
Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
@mariusandra
mariusandra merged commit 0b36bb4 into master Jul 16, 2026
202 of 203 checks passed
@mariusandra
mariusandra deleted the posthog-code/typegen-inline-batch-02 branch July 16, 2026 13:44
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-16 14:18 UTC Run
prod-us ✅ Deployed 2026-07-16 14:43 UTC Run
prod-eu ✅ Deployed 2026-07-16 14:43 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants