chore(surveys): regenerate kea types for optional param unions - #71591
chore(surveys): regenerate kea types for optional param unions#71591lricoy wants to merge 1 commit into
Conversation
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
|
This might be related to the typegen changes, so opening just in case but also checking |
|
Reviews (1): Last reviewed commit: "chore(surveys): regenerate kea types for..." | Re-trigger Greptile |
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pure generated-type regeneration (kea-typegen) matching the PR description exactly — adds | undefined to already-optional params, no runtime code touched, no risky territory.
- 👍 on the PR from chatgpt-codex-connector[bot], greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 35L, 3F substantive — within ceiling |
| tier | ✓ | T1-agent / T1b-small (35L, 3F, single-area, chore) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 29208dc · reviewed head de49322 |
🤖 CI report✅ Bundle size — no changeUncompressed size of every built Total: 64.82 MiB · no change No file changed by more than 1000 B. Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report ✅ Eager graph — within budgetHow much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy
🟢 Largest files eagerly shipped from
|
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.3 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.9 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 105.8 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🔺 +597 B (+0.0%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1320.76 MiB · 🔺 +597 B (+0.0%)
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
1 participant
Note
Superseded: an equivalent regeneration landed on master directly (master Frontend CI green as of 15:19 UTC, files now match this diff). Closing.
Problem
Master's
Frontend typecheckingjob has been failing since ~14:13 UTC today: the kea typegen check reports drift in three surveys logic type interfaces. #71456 ("inline Kea types batch 2") changed how kea-typegen renders optional action parameters (isDuplicate?: boolean→isDuplicate?: boolean | undefined), and these three files were not regenerated with it. Every in-flight PR fails the same check on its merge ref.Changes
Commits the checker's own regeneration diff — no hand-written changes — for:
frontend/src/scenes/surveys/forms/surveyFormBuilderLogic.tsfrontend/src/scenes/surveys/surveyLogic.tsxfrontend/src/scenes/surveys/wizard/surveyWizardLogic.tsType-level no-op (
T | undefinedon already-optional parameters); no runtime code touched.How did you test this code?
The diff is byte-for-byte what CI's typegen check printed as the expected content, so the check passes by construction; this PR's own
Frontend typecheckingrun is the verification. No new tests — generated type interfaces only.Automatic notifications
Docs update
Not applicable — generated types only.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
typegen:writewas rejected as the fix source: it produced a 21-file restructuring that doesn't match CI's environment. CI's printed diff is the deterministic ground truth and is what's committed here.