Skip to content

chore(desktop): resync products/desktop to PostHog/code fc991d3 - #76339

Merged
charlesvien merged 1 commit into
masterfrom
chore/desktop-resync-fc991d3
Aug 1, 2026
Merged

chore(desktop): resync products/desktop to PostHog/code fc991d3#76339
charlesvien merged 1 commit into
masterfrom
chore/desktop-resync-fc991d3

Conversation

@charlesvien

@charlesvien charlesvien commented Aug 1, 2026

Copy link
Copy Markdown
Member

Problem

products/desktop/ was pinned at PostHog/code 5ac5892 while the source repo moved on to fc991d3 (23 commits: mcp-gateway UI, canvas work, agent and Pi fixes). We need parity.

@charlesvien charlesvien self-assigned this Aug 1, 2026
@trunk-io

trunk-io Bot commented Aug 1, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review. (188 files found, 100 file limit)

Bypass the limit by tagging @greptile-apps to review.

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team August 1, 2026 09:14
import { unescapeXmlAttr } from "@posthog/shared";

const PI_SKILL_INVOCATION =
/^<skill name="([^"]+)" location="[^"]+">\n[\s\S]*?\n<\/skill>(?:\n\n([\s\S]+))?$/;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: Untrusted skill blocks are hidden from the transcript

This pattern treats any matching user-controlled message as a generated skill expansion and removes the block from the rendered transcript. A user can place arbitrary model instructions inside the block while teammates see only /name and the trailing text; collapse the content only when trusted invocation metadata identifies it as a genuine skill expansion, or retain the body for unverified messages.

@charlesvien
charlesvien merged commit 55c640d into master Aug 1, 2026
209 checks passed
@charlesvien
charlesvien deleted the chore/desktop-resync-fc991d3 branch August 1, 2026 09:17
@veria-ai

veria-ai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

PR overview

This PR resynchronizes the desktop product with PostHog code at commit fc991d3, including session transcript UI logic for displaying skill invocations.

One issue remains open in session transcript rendering. A user-controlled message can be mistaken for a generated skill expansion, hiding arbitrary model instructions from teammates and presenting a misleading abbreviated transcript. No issues have yet been addressed.

Open issues (1)

Fixed/addressed: 0 · PR risk: 5/10

@trunk-io

trunk-io Bot commented Aug 1, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@deployment-status-posthog

deployment-status-posthog Bot commented Aug 1, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-01 09:52 UTC Run
prod-us ✅ Deployed 2026-08-01 10:08 UTC Run
prod-eu ✅ Deployed 2026-08-01 10:10 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant