Skip to content

Conversation

@youngboy
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

see docs/readme.md

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gitguardian
Copy link

gitguardian bot commented Aug 12, 2022

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Algolia Keys 460923b packages/docs/.env View secret
4241586 Generic High Entropy Secret f79f715 packages/docs/src/components/header/header.tsx View secret
4241586 Generic High Entropy Secret 3f2a8bd packages/docs/src/components/header/header.tsx View secret
4241586 Generic High Entropy Secret ba3f77a packages/docs/src/components/header/header.tsx View secret
4241586 Generic High Entropy Secret f593238 packages/docs/src/components/header/header.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@youngboy youngboy marked this pull request as draft August 12, 2022 12:47
@youngboy youngboy changed the title Draft: Docs search feat: Docs search Aug 12, 2022
@youngboy youngboy marked this pull request as ready for review August 12, 2022 15:36
@youngboy
Copy link
Contributor Author

preview on https://yb-qwik.pages.dev/

@manucorporat
Copy link
Contributor

Amazing job! However I am a bit concerned about the eagerness of executing all react to support this. I would look into QwikReact to not run jS until the user interacts with the searchbar

@youngboy
Copy link
Contributor Author

Amazing job! However I am a bit concerned about the eagerness of executing all react to support this. I would look into QwikReact to not run jS until the user interacts with the searchbar

and could I help with write whole widget in qwik at all ? maybe functionality & accessible feature not comparable to official one, but I will try my best.

@youngboy
Copy link
Contributor Author

youngboy commented Aug 16, 2022

progress update: finished the MVP of search written in Qwik. Preview available in the same link https://yb-qwik.pages.dev/ . while it still can be improved for sophisticated UI, But I think it can be done later.

There is some issues currently I'm blocked for importing qwik components in npm

when I import bundled component, showing following errors

Error: QWIK http://localhost:3000/src/docsearch_component_useclienteffect_zrgf0h9ksk4.js#_hW[2] does not export _hW

Tried:

  1. change vite.config.ts qwik plugin's option entryStrategy to hook works fine with app dev.ssr, but failed with app build
  2. app directly import lib ts source files, works fine in dev.ssr & build, but failed with serve

@manucorporat
Copy link
Contributor

can i see the repo of qwik-algolia search?

@manucorporat
Copy link
Contributor

Found it! going to see if i can debug the issues with _hW make sure we are using the same version fo qwik, there are not cross compatibility yet

youngboy and others added 11 commits August 21, 2022 22:56
* main:
  feat: allow typeof onGet for DocumentHead (QwikDev#1065)
  docs: fix Syntax Error in React Counter Component (QwikDev#1076)
  docs: Add missing endpoint types to routing overview. (QwikDev#1064)
  fix: cloudflare pages starter (QwikDev#1083)
  feat: static site generation (QwikDev#1048)
  fix: root styles rendering (QwikDev#1095)
  docs: clarify useEffect usage a bit that can watch (QwikDev#1090)
  fix: useMount rendering order is respected (QwikDev#1094)
  feat: add Yaml Type (QwikDev#1086)
  fix: useClientEffect() runs in client-side mounted cmps (QwikDev#1092)
  feat: containerAttributes (QwikDev#1089)
  fix: properly serialize resources (QwikDev#1087)
  feat/fix: Export mdx frontmatter variables to the developer (QwikDev#1075)
  docs: Update README.md - Fix broken links (QwikDev#1071)
Co-authored-by: Félix Sanz <me@felixsanz.com>
* fix(css): correctly process vendor prefix and animation

* fixup! fix(css): correctly process vendor prefix and animation
@manucorporat manucorporat merged commit 2c0d67d into QwikDev:main Aug 22, 2022
@manucorporat
Copy link
Contributor

Thank you soo much! This was an amazing amount of work! Brilliant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants