rsx/fp: Fix precision clamping on MAD instruction - #8243
Merged
Conversation
elad335
reviewed
May 16, 2020
Contributor
woj1993
reviewed
May 16, 2020
woj1993
reviewed
May 16, 2020
Contributor
|
The sky is now blue in MLB The Show 14, but other problems (unrelated to this pr) are still present. https://cdn.discordapp.com/attachments/485204327800242177/711437885575921704/unknown.png |
2 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





RSX MAD instruction appears to be broken. Unlike other instructions, for this one only arg0 has clamping applied to it. However, when neg flag is set, the precision clamping works correctly. For example, consider this set of inputs (input clamping is set to [0,1] for all cases):
a) 1 * 100 + 0 = 100
b) 100 * 1 + 0 = 1
c) 1 * -100 + 0 = -1
d) 1* 1 + 100 = 101
etc
This fixes some rare graphical glitches such as the sea in one piece pirate warriors and the sky in GTA V. Also fixes post-processing in Crysis.
Fixes #2262